From ecb4519407b1dba094f58823baf2a7f41346b21a Mon Sep 17 00:00:00 2001 From: Caroline Cyr La Rose Date: Thu, 23 Oct 2025 15:05:03 -0400 Subject: [PATCH] Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields Signed-off-by: Owen Leonard Signed-off-by: David Nind --- .../en/modules/admin/preferences/acquisitions.pref | 2 +- .../prog/en/modules/admin/preferences/opac.pref | 8 ++++---- .../prog/en/modules/admin/preferences/patrons.pref | 10 +++++----- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref index 7f1a886095..c8f8d395d2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref @@ -9,7 +9,7 @@ Acquisitions: cataloguing: cataloging the record. - This is only the default behavior, and can be changed per-basket. - - - "The following database columns should be unique in an item:" + - "The following database columns should be unique in an item:" - pref: UniqueItemFields type: modalselect source: items diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index 8b4769c17e..37202dc17c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -844,19 +844,19 @@ OPAC: - "days after account creation." - "
NOTE: This system preference requires the misc/cronjobs/cleanup_database.pl cronjob. Ask your system administrator to schedule it.
No patrons will be deleted if you set the pref to zero or make it empty." - - - "The following database columns must be filled in on the patron modification screen:" + - "The following database columns must be filled in on the patron modification screen:" - pref: PatronSelfModificationMandatoryField type: modalselect source: borrowers exclusions: password|cardnumber|dateexpiry|categorycode|sort1|sort2|opacnote|borrowernotes|gonenoaddress|lost|flags - - - "The following database columns must be filled in on the patron entry screen:" + - "The following database columns must be filled in on the patron entry screen:" - pref: PatronSelfRegistrationBorrowerMandatoryField type: modalselect source: borrowers exclusions: sort1|sort2|opacnote|borrowernotes|gonenoaddress|lost|flags - - - "The following database columns will not appear on the patron self-registration screen:" + - "The following database columns will not appear on the patron self-registration screen:" - pref: PatronSelfRegistrationBorrowerUnwantedField type: modalselect source: borrowers @@ -864,7 +864,7 @@ OPAC: inclusions: categorycode|dateexpiry - '
NOTE: preferred_name will be set to firstname if not included in the form.' - - - "The following database columns will not appear on the patron self-modification screen:" + - "The following database columns will not appear on the patron self-modification screen:" - pref: PatronSelfModificationBorrowerUnwantedField type: modalselect source: borrowers diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref index eae4c9723f..533578e5b5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref @@ -213,7 +213,7 @@ Patrons: - pref: EmailFieldPrecedence class: multi - '
NOTE: All patron fields can be used, but to work correctly they must contain a valid email address or an empty string.' - - "Valid options are the database columns of the borrowers table, separated by | (pipe)." + - "Valid options are the database columns of the borrowers table, separated by | (pipe)." - "Example: email|emailpro|B_email" - - "When EmailFieldPrimary is set to 'selected addresses', send email to all valid email addresses in the selected fields:" @@ -276,14 +276,14 @@ Patrons: cron: (Deprecated) according to --send-notices cron switch Patron forms: - - - "The following database columns must be filled in on the patron entry screen:" + - "The following database columns must be filled in on the patron entry screen:" - pref: BorrowerMandatoryField type: modalselect source: borrowers exclusions: flags - 'NOTE: If autoMemberNum is enabled, the system preference BorrowerMandatoryField must not contain the field cardnumber.' - - - "The following database columns will not appear on the patron entry screen:" + - "The following database columns will not appear on the patron entry screen:" - pref: BorrowerUnwantedField type: modalselect source: borrowers @@ -313,7 +313,7 @@ Patrons: 0: "Don't" - store and display surnames in upper case. - - - "The following database columns:" + - "The following database columns:" - pref: PatronQuickAddFields type: modalselect source: borrowers @@ -339,7 +339,7 @@ Patrons: messaging: "Patron messaging preferences" - . - - - "The following database columns:" + - "The following database columns:" - pref: PatronDuplicateMatchingAddFields type: modalselect source: borrowers -- 2.39.5