From 449b492778fa174673a6197530c5d24d0aa143f4 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 22 Apr 2025 17:45:33 +0000 Subject: [PATCH] Bug 39715: Do not quote DataTables options This patch updates templates so that the options passed to DataTables (via kohaTable) are not quoted. The quotes are not necessary, and are not consistent with official DataTables documentation. This establishes a standard for us to follow in the future. The patch also corrects some option names which required upates, particularly "sorting" -> "order". To test, apply the patch and test updated DataTables. Sponsored-by: Athens County Public Libraries --- .../prog/en/includes/patron-search.inc | 162 +++++++++--------- .../prog/en/modules/acqui/acqui-home.tt | 14 +- .../prog/en/modules/acqui/lateorders.tt | 8 +- .../prog/en/modules/acqui/orderreceive.tt | 128 +++++++------- .../prog/en/modules/acqui/parcel.tt | 84 ++++----- .../prog/en/modules/acqui/parcels.tt | 2 +- .../prog/en/modules/admin/aqbudgetperiods.tt | 16 +- .../prog/en/modules/admin/aqbudgets.tt | 18 +- .../modules/admin/auth_subfields_structure.tt | 2 +- .../prog/en/modules/admin/background_jobs.tt | 66 +++---- .../prog/en/modules/admin/branches.tt | 84 ++++----- .../prog/en/modules/admin/cities.tt | 48 +++--- .../admin/identity_provider_domains.tt | 64 +++---- .../en/modules/admin/marc-overlay-rules.tt | 26 +-- .../prog/en/modules/admin/smtp_servers.tt | 68 ++++---- .../prog/en/modules/bookings/list.tt | 76 ++++---- .../prog/en/modules/catalogue/detail.tt | 52 +++--- .../prog/en/modules/catalogue/itemsearch.tt | 20 +-- .../prog/en/modules/cataloguing/concerns.tt | 52 +++--- .../prog/en/modules/circ/curbside_pickups.tt | 2 +- .../prog/en/modules/circ/pendingbookings.tt | 92 +++++----- .../prog/en/modules/clubs/patron-clubs-tab.tt | 2 +- .../prog/en/modules/members/discharges.tt | 1 - .../prog/en/modules/patron_lists/lists.tt | 2 +- .../intranet-tmpl/prog/en/modules/pos/pay.tt | 33 ++-- .../prog/en/modules/pos/register.tt | 38 ++-- .../modules/reports/guided_reports_start.tt | 8 +- .../prog/en/modules/suggestion/suggestion.tt | 2 +- .../prog/en/modules/tools/inventory.tt | 14 +- .../en/modules/tools/manage-marc-import.tt | 30 ++-- .../prog/en/modules/virtualshelves/shelves.tt | 34 ++-- .../virtualshelves/tables/shelves_results.tt | 2 +- .../bootstrap/en/modules/opac-account.tt | 26 +-- .../en/modules/opac-course-reserves.tt | 2 +- .../bootstrap/en/modules/opac-detail.tt | 2 +- .../bootstrap/en/modules/opac-holdshistory.tt | 2 +- .../bootstrap/en/modules/opac-suggestions.tt | 10 +- .../bootstrap/en/modules/opac-tags.tt | 2 +- .../bootstrap/en/modules/opac-topissues.tt | 2 +- .../bootstrap/en/modules/opac-user.tt | 18 +- .../bootstrap/en/modules/sco/sco-main.tt | 2 +- 41 files changed, 657 insertions(+), 659 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc index a4f76e8e116..2d603c0d839 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc @@ -476,9 +476,9 @@ [% SET embed = ['extended_attributes','library'] %] let table_node = $("#[% table_id | html %]"); patrons_table = table_node.kohaTable({ - "ajax": { - "url": patron_search_url, - "dataSrc": function ( json ) { + ajax: { + url: patron_search_url, + dataSrc: function ( json ) { [% IF redirect_if_one_result %] // redirect if there is only 1 result. // Do not redirect if state has been loaded @@ -496,7 +496,7 @@ } }, [% IF open_on_row_click OR preview_on_name_click OR remember_selections %] - "drawCallback": function( settings ) { + drawCallback: function( settings ) { var api = this.api(); var data = api.data(); if ( data.length == 0 ) return; @@ -520,8 +520,8 @@ [% END %] }, [% END %] - "deferLoading": defer_loading, - "columns": [ + deferLoading: defer_loading, + columns: [ [% FOR column IN columns %] [% IF default_sort_column == column %] [% order_column_index = loop.count - 1%] @@ -529,19 +529,19 @@ [% SWITCH column %] [% CASE 'checkbox' %] { - "data": "patron_id", - "searchable": false, - "orderable": false, - "render": function( data, type, row, meta ) { + data: "patron_id", + searchable: false, + orderable: false, + render: function( data, type, row, meta ) { return ""; } } [% CASE 'cardnumber' %] { - "data": "cardnumber", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "cardnumber", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { let patron_id = encodeURIComponent(row.patron_id); [% IF !open_on_row_click AND CAN_user_circulate_circulate_remaining_permissions %] return "" + escape_str(data) + ""; @@ -553,20 +553,20 @@ } [% CASE 'dateofbirth' %] { - "data": "date_of_birth", - "type": "date", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "date_of_birth", + type: "date", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { return data ? "" + escape_str($date(data)) + " (" + _("%s years").format($get_age(data)) + ")" : ""; } } [% CASE 'address' %] { - "data": "me.street_number:me.address:me.address2:me.city:me.state:me.postal_code:me.country", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "me.street_number:me.address:me.address2:me.city:me.state:me.postal_code:me.country", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { let r = '
'; @@ -575,10 +575,10 @@ } [% CASE 'address-library' %] { - "data": "me.street_number:me.address:me.address2:me.city:me.state:me.postal_code:me.country", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "me.street_number:me.address:me.address2:me.city:me.state:me.postal_code:me.country", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { let r = '
'; @@ -588,10 +588,10 @@ } [% CASE 'name-address' %] { - "data": "me.surname:me.preferred_name:me.firstname:me.middle_name:me.othernames:me.street_number:me.address:me.address2:me.city:me.state:me.postal_code:me.country", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "me.surname:me.preferred_name:me.firstname:me.middle_name:me.othernames:me.street_number:me.address:me.address2:me.city:me.state:me.postal_code:me.country", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { let patron_id = encodeURIComponent(row.patron_id); let r = ''; [% IF ! open_on_row_click %] @@ -613,10 +613,10 @@ } [% CASE 'name' %] { - "data": "me.surname:me.preferred_name:me.firstname:me.middle_name:me.othernames", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "me.surname:me.preferred_name:me.firstname:me.middle_name:me.othernames", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { let patron_id = encodeURIComponent(row.patron_id); [% IF ! open_on_row_click %] return "" + $patron_to_html(row, { invert_name: 1 }) + ""; @@ -627,10 +627,10 @@ } [% CASE 'branch' %] { - "data": "library.name:me.library_id", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "library.name:me.library_id", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { if( !singleBranchMode && row.library.library_id == logged_in_library_id ) { return "" + escape_str(row.library.name) + ""; } else { @@ -640,45 +640,45 @@ } [% CASE 'category' %] { - "data": "category_id", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "category_id", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { return escape_str(categories_map[data.toLowerCase()].description); } } [% CASE 'dateexpiry' %] { - "data": "expiry_date", - "type": "date", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "expiry_date", + type: "date", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { return "" + (data ? escape_str($date(data)) : '') + ""; } } [% CASE 'borrowernotes' %] { - "data": "staff_notes", - "searchable": true, - "orderable": true, + data: "staff_notes", + searchable: true, + orderable: true, [%# We don't escape here, we allow html tag in staff notes %] } [% CASE 'phone' %] { - "data": "phone", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "phone", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { return escape_str(data); } } [% CASE 'checkouts' %][% embed.push('checkouts+count', 'overdues+count') %] { - "data": "", - "searchable": false, - "orderable": false, - "render": function( data, type, row, meta ) { + data: "", + searchable: false, + orderable: false, + render: function( data, type, row, meta ) { if ( row.overdues_count ) { return ""+row.overdues_count + "" + " / " + row.checkouts_count; } else { @@ -688,10 +688,10 @@ } [% CASE 'account_balance' %][% embed.push('account_balance') %] { - "data": "", - "searchable": false, - "orderable": false, - "render": function( data, type, row, meta ) { + data: "", + searchable: false, + orderable: false, + render: function( data, type, row, meta ) { let r = ""; let balance_str = row.account_balance || 0; balance_str = balance_str.escapeHtml().format_price(); @@ -711,10 +711,10 @@ [% CASE 'sort1' %] { - "data": "statistics_1", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "statistics_1", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { if (data === null) return ''; let bsort1 = av_bsort1_map[data.toString()]; return escape_str(bsort1 ? bsort1.lib : data); @@ -723,10 +723,10 @@ [% CASE 'sort2' %] { - "data": "statistics_2", - "searchable": true, - "orderable": true, - "render": function( data, type, row, meta ) { + data: "statistics_2", + searchable: true, + orderable: true, + render: function( data, type, row, meta ) { if (data === null) return ''; let bsort2 = av_bsort2_map[data.toString()]; return escape_str(bsort2 ? bsort2.lib : data); @@ -736,7 +736,7 @@ [% CASE 'action' %] { - "data": function( row, type, val, meta ) { + data: function( row, type, val, meta ) { let patron_id = encodeURIComponent(row.patron_id); let action_node = ""; @@ -764,21 +764,21 @@ return action_node; }, - "searchable": false, - "orderable": false + searchable: false, + orderable: false } [% END %] [% UNLESS loop.last %],[% END %] [% END %] ], - 'embed': [% To.json(embed) | $raw %], - "order": [[ [% order_column_index | html %], "asc" ]], - "autoWidth": false, - 'lengthMenu': [aLengthMenu, aLengthMenuLabel], - "pagingType": 'full_numbers', - "pageLength": [% Koha.Preference('PatronsPerPage') | html %], + embed: [% To.json(embed) | $raw %], + order: [[ [% order_column_index | html %], "asc" ]], + autoWidth: false, + lengthMenu: [aLengthMenu, aLengthMenuLabel], + pagingType: 'full_numbers', + pageLength: [% Koha.Preference('PatronsPerPage') | html %], [% IF sticky_header %] - "initComplete": function(settings, json) { + initComplete: function(settings, json) { $("#[% sticky_header | html %]").show(); }, [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt index 1951395a132..7049c2f18e1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt @@ -213,7 +213,7 @@ $(document).ready(function() { var table_settings = [% TablesSettings.GetTableSettings( 'acqui', 'acq_acqui-home', 'accounts', 'json' ) | $raw %]; var oTable = $("#accounts").kohaTable({ - "drawCallback": function ( oSettings ) { + drawCallback: function ( oSettings ) { if ( oSettings.aiDisplay.length == 0 ) { return; @@ -239,17 +239,17 @@ } } }, - "footerCallback": function ( row, data, start, end, display ) { + footerCallback: function ( row, data, start, end, display ) { var api = this.api(), data; footer_column_sum( api, [ 6, 7, 8, 9 ] ); }, - "columnDefs": [ + columnDefs: [ { "orderable": false, "targets": ["_all"] } ], - "ordering": true, - "orderFixed": [[ 1, 'asc' ]], - "paginate": false, - "autoWidth": false + ordering: true, + orderFixed: [[ 1, 'asc' ]], + paginate: false, + autoWidth: false }, table_settings ); let table_dt = oTable.DataTable(); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt index 9fb6877b9c6..4fd290a225e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt @@ -390,10 +390,10 @@ var table_settings = [% TablesSettings.GetTableSettings( 'acqui', 'lateorders', 'late_orders', 'json' ) | $raw %]; late_orderst = $("#late_orders").kohaTable({ - "sorting": [[ 1, "asc" ]], - "pagingType": "full", - "autoWidth": false, - "drawCallback": function() { + order: [[ 1, "asc" ]], + pagingType: "full", + autoWidth: false, + drawCallback: function() { if ( typeof late_orderst != 'undefined' ) { check_uncheck(); $('input:checkbox[name=ordernumber]').bind('click', check_uncheck); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt index 8cb5d28e09f..f1c4085ff3d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt @@ -552,28 +552,28 @@ var base_query = { "order_id": {"-in": [[% multiple_orders | html %]]}}; var pending_orders_url = "/api/v1/acquisitions/orders?only_active=1"; var options = { - "ajax": { + ajax: { "url": pending_orders_url + "&q=" + encodeURI(JSON.stringify(base_query)) }, - "embed": [ + embed: [ "basket", "biblio.suggestions.suggester", "fund.budget", "items+strings", "creator" ], - 'dom': 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>', - "columns": [ + dom: 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>', + columns: [ { - "data": "order_id", - "searchable": true, - "orderable": true + data: "order_id", + searchable: true, + orderable: true }, { - "data": "biblio.title", - "searchable": true, - "orderable": true, - "render": function(data, type, row, meta) { + data: "biblio.title", + searchable: true, + orderable: true, + render: function(data, type, row, meta) { if ( data == null ) { return ""; } @@ -583,10 +583,10 @@ } }, { - "data": "biblio.author", - "searchable": true, - "orderable": true, - "render": function(data, type, row, meta) { + data: "biblio.author", + searchable: true, + orderable: true, + render: function(data, type, row, meta) { if ( data == null ) { return ""; } @@ -596,10 +596,10 @@ } }, { - "data": "biblio.isbn", - "searchable": true, - "orderable": true, - "render": function(data, type, row, meta) { + data: "biblio.isbn", + searchable: true, + orderable: true, + render: function(data, type, row, meta) { if ( data == null ) { return ""; } @@ -609,39 +609,39 @@ } }, { - "searchable": false, - "orderable": false, - "data": function(row, type, val, meta) { + searchable: false, + orderable: false, + data: function(row, type, val, meta) { return $date(row.date_received||new Date().toISOString()); } }, { - "data": "fund.name", - "searchable": true, - "orderable": false, - "render": function(data, type, row, meta) { + data: "fund.name", + searchable: true, + orderable: false, + render: function(data, type, row, meta) { return row.fund.budget.budget_period_description+" - "+row.fund.name; } }, { - "searchable": false, - "orderable": true, - "data": "quantity_received", - "render": function(data, type, row, meta) { + searchable: false, + orderable: true, + data: "quantity_received", + render: function(data, type, row, meta) { var data = $("#order_edit").data(); return QTY_TOTAL.format(row.subscription_id&&(!data.saved||!data.saved.hasOwnProperty(row.order_id))?row.quantity:row.quantity_received, row.quantity); } }, { - "searchable": false, - "orderable": false, - "render": function(data, type, row, meta) { + searchable: false, + orderable: false, + render: function(data, type, row, meta) { return ' '+EDIT+''; } } ], [% IF only_one_order %] - "drawCallback": function( settings ) { + drawCallback: function( settings ) { $("#order_edit").modal("show"); }, [% END %] @@ -1017,20 +1017,20 @@ var base_query = { "subscription_id": row.subscription_id, "parent_order_id": row.order_id, "order_id": {"!=": row.order_id}}; var pending_orders_url = "/api/v1/acquisitions/orders"; var options = { - "ajax": { + ajax: { "url": pending_orders_url + "?q=" + encodeURI(JSON.stringify(base_query)) }, - "embed": [ + embed: [ "invoice", "basket" ], - "order": [[1, 'asc']], - 'dom': 'C<"top pager"ilpfB>tr<"bottom pager"ip>', - "columns": [ + order: [[1, 'asc']], + dom: 'C<"top pager"ilpfB>tr<"bottom pager"ip>', + columns: [ { - "searchable": false, - "orderable": false, - "data": function(row, type, val, meta) { + searchable: false, + orderable: false, + data: function(row, type, val, meta) { if(row.invoice) { if(CAN_user_acquisition) { return ''+row.invoice.invoice_number+""; @@ -1040,53 +1040,53 @@ } }, { - "data": "order_id", - "searchable": false, - "orderable": false + data: "order_id", + searchable: false, + orderable: false }, { - "searchable": false, - "orderable": false, - "data": "basket.creation_date", - "render": function(data, type, row, meta) { + searchable: false, + orderable: false, + data: "basket.creation_date", + render: function(data, type, row, meta) { return $date(row.basket.creation_date); } }, { - "searchable": false, - "orderable": false, - "data": function(row, type, val, meta) { + searchable: false, + orderable: false, + data: function(row, type, val, meta) { return $date(row.date_received); } }, { - "searchable": false, - "orderable": false, - "data": function(row, type, val, meta) { + searchable: false, + orderable: false, + data: function(row, type, val, meta) { return row.quantity_received; } }, { - "searchable": false, - "orderable": true, - "data": function(row, type, val, meta) { + searchable: false, + orderable: true, + data: function(row, type, val, meta) { if(!row.status) return; var first_letter = row.status[0].toUpperCase(); return first_letter+row.status.substr(1).toLowerCase(); } }, { - "searchable": false, - "orderable": false, - "data": function(row, type, val, meta) { + searchable: false, + orderable: false, + data: function(row, type, val, meta) { if(!row.date_received) return; return Number(row.unit_price_tax_excluded * row.quantity_received).format_price()+' / '+Number(row.unit_price_tax_included * row.quantity_received).format_price() } }, { - "searchable": false, - "orderable": false, - "data": function(row, type, val, meta) { + searchable: false, + orderable: false, + data: function(row, type, val, meta) { return row.internal_note; } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt index 410c55d95cb..1970eebf1e4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt @@ -396,10 +396,10 @@ } var options = { - "ajax": { + ajax: { "url": '/api/v1/acquisitions/orders?only_active=1' }, - "embed": [ + embed: [ "basket.basket_group", "biblio.uncancelled_orders+count", "biblio.holds+count", @@ -409,18 +409,18 @@ "current_item_level_holds+count", "items" ], - "columns": [ - { "data": "basket.name", - "searchable": true, - "orderable": true, - "render": function(data, type, row, meta) { + columns: [ + { data: "basket.name", + searchable: true, + orderable: true, + render: function(data, type, row, meta) { if (type != 'display') return escape_str(data); return "" + escape_str(data) + " (" + escape_str(row.basket.basket_id) + ")"; } }, - { "data": "basket.basket_group.name", - "orderable": true, - "render": function(data, type, row, meta) { + { data: "basket.basket_group.name", + orderable: true, + render: function(data, type, row, meta) { if ( type != 'display' ) { return escape_str(data); } @@ -436,8 +436,8 @@ } }, { - "data": "order_id", - "render": function(data, type, row, meta) { + data: "order_id", + render: function(data, type, row, meta) { if (type != 'display') return escape_str(data); return ""+escape_str(data)+""; } @@ -445,8 +445,8 @@ { [% SET summary_fields = "biblio.title:biblio.author:biblio.isbn:biblio.publisher:me.internal_note:me.vendor_note" %] [% IF Koha.Preference('marcflavour')=='UNIMARC' %][% SET summary_fields = summary_fields _ ":biblio.ean" %][% END %] - "data": "[% summary_fields | html %]", - "render": function(data, type, row, meta) { + data: "[% summary_fields | html %]", + render: function(data, type, row, meta) { var result = ''; if ( row && row.biblio_id != null ) { result = "

"+escape_str(row.biblio.title)+""; @@ -520,11 +520,11 @@ return result; }, - "orderable": true, + orderable: true, }, { - "data": "", - "render": function(data, type, row, meta) { + data: "", + render: function(data, type, row, meta) { var result = '

'; result += ''; @@ -538,55 +538,55 @@ result += '
'; return result; }, - "orderable": false, - "searchable": false + orderable: false, + searchable: false }, { - "data": "replacement_price", - "render": function(data, type, row, meta) { + data: "replacement_price", + render: function(data, type, row, meta) { return escape_price(row.replacement_price); }, }, { - "data": "quantity", - "orderable": true + data: "quantity", + orderable: true }, { - "data": "ecost", - "render": function(data, type, row, meta) { + data: "ecost", + render: function(data, type, row, meta) { return escape_price(row.ecost); }, }, { - "data": "", - "render": function(data, type, row, meta) { + data: "", + render: function(data, type, row, meta) { return escape_price(row.quantity * row.ecost); }, - "orderable": false, // FIXME: How can we do it in DBIC? - "searchable": false + orderable: false, // FIXME: How can we do it in DBIC? + searchable: false }, { - "data": "fund.name", - "render": function(data, type, row, meta) { + data: "fund.name", + render: function(data, type, row, meta) { if (type != 'display') return escape_str(data); return escape_str(row.fund.name); } }, { - "data": "", - "render": function(data, type, row, meta) { + data: "", + render: function(data, type, row, meta) { return '' + _("Receive") + '
' + '' + _("Transfer") + ''; }, - "orderable": false, - "searchable": false + orderable: false, + searchable: false }, { - "data": "", - "render": function(data, type, row, meta) { + data: "", + render: function(data, type, row, meta) { var result = ""; if ( row.current_holds_count > 0 ) { @@ -644,8 +644,8 @@ return result; }, - "orderable": false, - "searchable": false + orderable: false, + searchable: false } ] }; @@ -658,11 +658,11 @@ }).html(PENDING_MULTI_SELECTION.format('0')) options.order = [[1, 'asc']]; options.columns.unshift({ - "data": function (row, type, val, meta) { + data: function (row, type, val, meta) { return ''; }, - "searchable": false, - "orderable": false + searchable: false, + orderable: false }); let table_settings = [% TablesSettings.GetTableSettings( 'acqui', 'parcel', 'pending_orders', 'json' ) | $raw %]; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt index 08b89893a13..4170bf903ce 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt @@ -272,7 +272,7 @@