From e075b48c92c81f44b8823110d649583a2ce85dd6 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 24 Oct 2025 16:25:44 +0000 Subject: [PATCH] Bug 41082: Fix batch tools from reports when itemnumber col has been renamed Description from comment 0 When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. Test plan: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again => verify the items are shown above the item form Signed-off-by: Owen Leonard Signed-off-by: Brendan Lawlor --- .../prog/en/modules/reports/guided_reports_start.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index aeb679955f..b3ec9ad307 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1001,7 +1001,7 @@ [% IF header_row.$place.cell == 'itemnumber' || header_types.item(header_row.$place.cell) == 'itemnumber' %] [% SET batch_itemnumbers = 1 %] [% SET header_row.$place.has_itemnumbers = 1 %] - + [% END %] [% END %] [% END %] @@ -1018,7 +1018,7 @@ [% IF header_row.$place.cell == 'itemnumber' || header_types.item(header_row.$place.cell) == 'itemnumber' %] [% SET batch_itemnumbers = 1 %] [% SET header_row.$place.has_itemnumbers = 1 %] - + [% END %] [% END %] [% END %] -- 2.39.5