From 2ff6e1c91ed07b3879e86182ea806a258a11480b Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 24 Oct 2025 14:50:23 -0400 Subject: [PATCH] Bug 41100: EDI vendor account port numbers no longer editable It seems that port numbers are stuck at 21. Editing them does not change the port number in the database. Test Plan: 1) Check out Koha 25.05 2) Try to edit an EDI vendor account port 3) Note the change doesn't save 4) Apply this patch 5) Restart all the things! 6) Note you can edit the port again! Signed-off-by: David Nind Signed-off-by: Aleisha Amohia --- admin/edi_accounts.pl | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/admin/edi_accounts.pl b/admin/edi_accounts.pl index 410bcb8eaf4..9d039e9e656 100755 --- a/admin/edi_accounts.pl +++ b/admin/edi_accounts.pl @@ -75,12 +75,16 @@ if ( $op eq 'acct_form' ) { my $password = scalar $input->param('password'); $password = $crypt->encrypt_hex($password); my $fields = { - description => scalar $input->param('description'), - host => scalar $input->param('host'), - username => scalar $input->param('username'), - password => $password, - upload_port => scalar $input->param('upload_port') || $input->param('transport') eq 'FTP' ? 21 : 22, - download_port => scalar $input->param('download_port') || $input->param('transport') eq 'FTP' ? 21 : 22, + description => scalar $input->param('description'), + host => scalar $input->param('host'), + username => scalar $input->param('username'), + password => $password, + upload_port => scalar $input->param('upload_port') ? scalar $input->param('upload_port') + : $input->param('transport') eq 'FTP' ? 21 + : 22, + download_port => scalar $input->param('download_port') ? scalar $input->param('download_port') + : $input->param('transport') eq 'FTP' ? 21 + : 22, vendor_id => scalar $input->param('vendor_id'), upload_directory => scalar $input->param('upload_directory'), download_directory => scalar $input->param('download_directory'), -- 2.39.5