From be0dc555e8aaf3e90b7c65356c4a0089f910bb6c Mon Sep 17 00:00:00 2001 From: Eric Garcia Date: Tue, 12 Aug 2025 15:48:14 +0000 Subject: [PATCH] Bug 35211: Fix tab building Fixed naming when building tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer Signed-off-by: Paul Derscheid --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index f0884efbc78..0268bbae276 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -335,9 +335,9 @@ [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] [% FOREACH group IN lib_groups %] - [% IF ( holdings_count.${group.id} > 0 ) %] + [% IF ( holdings_count_hash.${group.id} > 0 ) %] [% WRAPPER tab_item tabname="group_holdings_" _ group.id %] - [% group.title | html %] holdings ([% holdings_count.${group.id} | html %]) + [% group.title | html %] holdings ([% holdings_count_hash.${group.id} | html %]) [% END %] [% END %] [% END %] @@ -492,7 +492,7 @@ [% END %] [% IF Koha.Preference('SeparateHoldingsByGroup') && lib_groups %] [% FOREACH group IN lib_groups %] - [% IF ( holdings_count.${group.id} > 0 ) %] + [% IF ( holdings_count_hash.${group.id} > 0 ) %] [% SET group_tab = "group_holdings_" _ group.id %] [% WRAPPER tab_panel tabname=group_tab %] [% PROCESS items_table tab=group_tab %] -- 2.39.5