From 7412495582606139991263d6b446bcaf123c22a9 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 30 Oct 2025 13:34:08 +0000 Subject: [PATCH] Bug 23415: Fix FineNoRenewals to use non_issues_charges and improve template This commit addresses two issues: 1. Fixes FineNoRenewals logic to properly use non_issues_charges Both CanBookBeRenewed() and _CanBookBeAutoRenewed() were incorrectly using the patron's total balance when checking against FineNoRenewals. They now use non_issues_charges, which returns only charges that should restrict checkouts (e.g., overdues, lost items) as defined by debit types with restricts_checkouts=1. This ensures charges like rental fees don't inappropriately block renewals. 2. Improves renewal template for AllowFineOverrideRenewing - Adds special handling for auto_too_much_owing error to check AllowFineOverrideRenewing preference instead of AllowRenewalLimitOverride - Adds missing id="barcode" attribute to input field for Cypress tests - Adds .dialog CSS class to error/success divs for consistent styling - Fixes HTML structure with proper