From 1f4cdd7b0432cf97205b999ecd79e3d6bc70077f Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 2 Nov 2020 13:48:39 +0000 Subject: [PATCH] Bug 40559: Fix noisy warning in MARCdetail Content-Type: text/plain; charset=utf-8 Rebased for 25.06. Resolves: Use of uninitialized value in string eq at /usr/share/koha/catalogue/MARCdetail.pl line 203. Test plan: Make sure that there is a combination of framework/field/subfield having an entry in marc_subfield_structure where kohafield is NULL. To force this for default fw on 020$q: update marc_subfield_structure set kohafield=NULL where tagfield='020' and tagsubfield='q' and frameworkcode=''; Pick a biblio in this framework having that field/subfield. Or create a 020 with $q filled. Hit catalogue/MARCdetail now. Without this patch, it triggers the warn. With this patch, it does not. Signed-off-by: Marcel de Rooy --- catalogue/MARCdetail.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl index a37b3656f3..9ce9cc5f73 100755 --- a/catalogue/MARCdetail.pl +++ b/catalogue/MARCdetail.pl @@ -200,7 +200,9 @@ for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) { if ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{isurl} ) { $subfield_data{marc_value} = $subf[$i][1]; $subfield_data{is_url} = 1; - } elsif ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{kohafield} eq "biblioitems.isbn" ) { + } elsif ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{kohafield} + && $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{kohafield} eq "biblioitems.isbn" ) + { # warn " tag : ".$tagslib->{$fields[$x_i]->tag()}." subfield :".$tagslib->{$fields[$x_i]->tag()}->{$subf[$i][0]}. "ISBN : ".$subf[$i][1]."PosttraitementISBN :".DisplayISBN($subf[$i][1]); $subfield_data{marc_value} = $subf[$i][1]; -- 2.39.5