From ed36c89f9c65eaa282480415eb198982544c6594 Mon Sep 17 00:00:00 2001 From: Jake Deery Date: Thu, 23 Oct 2025 12:10:30 +0100 Subject: [PATCH] Bug 41177: Add aria-disabled to breadcrumbs This patch adds aria-disabled and tabindex = -1 to a breadcrumb, if it is the current page. This aids in accesssibility, and is generally good practice. == TO TEST: == a) Visit any page on the OPAC, and inspect the breadcrumb pertinent to the current page *) Notice the lack of aria-disabled and tabindex on the inspected element == APPLY PATCH == b) repeat step a *) Notice how there is now an aria-disabled and tabindex = -1 *) Notice you cannot tab on to the final breadcrumb anymore c) Ensure other breadcrumbs are unaffected and still work as links == SIGN OFF == --- koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 2 +- t/mock_templates/intranet-tmpl/prog/en/modules/about.tt | 2 +- t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc index 0fc0fcf0401..555148d1081 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc @@ -570,7 +570,7 @@ [% IF content.trim %] [% IF ( bc_active ) %] [% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc index d267032d37c..4646a0f9135 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc @@ -64,7 +64,7 @@ [% IF ( languages_loo.group_enabled ) %] [% IF ( languages_loo.current ) %]
  • - [% PAGE_NUMBER.pg | html %] + [% PAGE_NUMBER.pg | html %]
  • [% ELSE %]
  • diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index 7d8e3d4bdad..32cb6491357 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -26,7 +26,7 @@ [% WRAPPER 'sub-header.inc' %] [% WRAPPER breadcrumbs %] [% WRAPPER breadcrumb_item %] - About Koha + About Koha [% END %] [% END %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt index afd9a028d82..26bd1d0cd5d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt @@ -34,7 +34,7 @@ Administration [% END %] [% WRAPPER breadcrumb_item %] - + Record overlay rules [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt index 87596b65949..8f72042a2a1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt @@ -20,7 +20,7 @@ [% WRAPPER 'sub-header.inc' %] [% WRAPPER breadcrumbs %] [% WRAPPER breadcrumb_item %] - [% tx("Error {error_number}", {error_number = errno }) | html %] + [% tx("Error {error_number}", {error_number = errno }) | html %] [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt index 82ab5e5ac84..0876c23f627 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt @@ -16,7 +16,7 @@ [% FOREACH number IN numbers %] [% IF ( startfrom == number.startfrom ) %]
  • - [% number.number | html %] + [% number.number | html %]
  • [% ELSE %]
  • diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc index 8f8cc445353..15b1278c76c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc @@ -159,7 +159,7 @@ [% BLOCK breadcrumb_item %] [% IF ( bc_active ) %]
  • [% ELSE %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt index fd4a401df91..e4c8dd333ff 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt @@ -27,7 +27,7 @@ [% INCLUDE 'patron-title.inc' patron = logged_in_user %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt index 4154af5551f..2a2a2e5e125 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt @@ -23,7 +23,7 @@ [% INCLUDE 'patron-title.inc' patron = logged_in_user %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt index f0ddd57f1ad..2364b24b892 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt @@ -60,7 +60,7 @@ [% END %] [% ELSE %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Interlibrary loan requests + Interlibrary loan requests [% END %] [% END %] [% END #/ WRAPPER breadcrumbs %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt index e5e0cff8546..3458d11b00f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt @@ -31,7 +31,7 @@ [% INCLUDE 'patron-title.inc' patron = logged_in_user %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt index 6df0282c76b..8ee46dbc434 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt @@ -31,7 +31,7 @@ Catalog search for '[% q | html %]' diff --git a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt index 692fca861f5..73f35942ffd 100644 --- a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt +++ b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt @@ -21,7 +21,7 @@ [% WRAPPER 'sub-header.inc' %] [% WRAPPER breadcrumbs %] [% WRAPPER breadcrumb_item %] - About Koha + About Koha [% END %] [% END %] [% END %] diff --git a/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt b/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt index 6de9b8c5151..7a7988b341a 100644 --- a/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt +++ b/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt @@ -21,7 +21,7 @@ [% WRAPPER 'sub-header.inc' %] [% WRAPPER breadcrumbs %] [% WRAPPER breadcrumb_item %] - About Koha + About Koha [% END %] [% END %] [% END %] -- 2.50.1 (Apple Git-155)