From 25a2c74c30cad1117d375ece6fcd0b34deb2442f Mon Sep 17 00:00:00 2001 From: Jake Deery Date: Thu, 2 Oct 2025 12:21:48 +0000 Subject: [PATCH] Bug 41201: Removed definite article from hold and cart This patch removes the definite article from some labels, so that their visual and hidden labels are in sync. == TO TEST == a) (optionally) read the patch code to understand what locations have change b) inspect the code on the results and details pages c) note that some visual and hidden labels differ *) specifically, the add to cart and place hold labels == APPLY PATCH == d) repeat step b) e) notice now that the visual and hidden labels match == SIGN OFF == Signed-off-by: Owen Leonard --- .../intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- .../bootstrap/en/includes/title-actions-menu.inc | 8 ++++---- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 14868aaff46..e75e33c44f0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -27,7 +27,7 @@ >[% FILTER collapse %] [% UNLESS ( multi_hold ) %] [% title_in_title = INCLUDE 'biblio-title-head.inc' %] - [% tx("Place a hold on {title}", { title = title_in_title }) | html %] + [% tx("Place hold on {title}", { title = title_in_title }) | html %] › [% ELSE %] [% t("Confirm holds") | html %] @@ -286,7 +286,7 @@ [% END %] [% UNLESS ( multi_hold ) %] -

Place a hold on [% INCLUDE 'biblio-title.inc' link = 1 %] [% IF biblio.author %]by [% biblio.author | html %][% END %]

+

Place hold on [% INCLUDE 'biblio-title.inc' link = 1 %] [% IF biblio.author %]by [% biblio.author | html %][% END %]

[% ELSE %]

[% IF ( patron ) %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc index cffc84910f6..0cb2ba1361f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc @@ -4,14 +4,14 @@ [% IF ( shelf AND op == 'view' ) # Lists view has more granular checking of hold availability %] [% IF ( items.allow_onshelf_holds ) %] Place hold [% ELSE %] [% IF ( items.itemsissued ) %] Place hold @@ -19,7 +19,7 @@ [% END %] [% ELSE %] Place hold @@ -87,7 +87,7 @@ > [% ELSE %] Add to cart - + [% END # / bibitemloo.holdable %] @@ -598,13 +598,13 @@ $(".confirmjs_hold").each(function(){ var bib = $(this).attr("title"); var html = " "; + html += "value=\"" + bib + "\" id=\"" + bib + "\" /> " + _("Place hold on") + " "; $(this).html(html); }); $(".confirmjs_nohold").each(function(){ var bib = $(this).attr("title"); var html = ""; + html += "value=\"" + bib + "\" id=\"" + bib + "\" />" + _("Place hold on: ") + ""; $(this).html(html); }); -- 2.39.5