From d71e7af539262bc2ac951ae75595a013d2863afc Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 6 Nov 2025 16:22:21 +0000 Subject: [PATCH] Bug 41177: (follow-up) A few minor corrections This patch makes the following corrections: - Remove link from breadcrumb WRAPPER items. The right markup is generated in html_helpers.inc if you add the "bc_active = 1" to the breadcrumb_item WRAPPER. - Remove "href='#'" from inactive links, and adjust CSS accordingly. The W3C validator doesn't like it when a true "aria-disabled" attribute is on a link which has an href attribute. --- .../prog/css/src/staff-global.scss | 21 +++++++------------ .../prog/en/includes/html_helpers.inc | 2 +- .../prog/en/includes/intranet-bottom.inc | 6 +++--- .../intranet-tmpl/prog/en/modules/about.tt | 4 ++-- .../en/modules/admin/marc-overlay-rules.tt | 6 ++---- .../prog/en/modules/errors/errorpage.tt | 4 ++-- .../opac-tmpl/bootstrap/css/src/opac.scss | 9 ++------ .../bootstrap/en/includes/html_helpers.inc | 2 +- .../bootstrap/en/modules/opac-illrequests.tt | 2 +- 9 files changed, 21 insertions(+), 35 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 44c3229cf13..25b3e996972 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -3076,11 +3076,12 @@ nav { margin-right: .3rem; width: .8em; } - /*rtl:raw: - &::before { - transform: scaleX(-1); + } + + &.active { + a { + pointer-events: none; } - */ } } @@ -3623,18 +3624,10 @@ input.renew { &.currentlanguage { color: #000; font-weight: bold; - } - } - - a { - &.currentlanguage { - &:link, - &:visited { - font-weight: bold; - } + pointer-events: none; } - .sublanguage-selected { + &.sublanguage-selected { color: #000; font-weight: bold; } diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc index 0fd5d35f32a..f3924534546 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc @@ -566,7 +566,7 @@ [% IF content.trim %] [% IF ( bc_active ) %] [% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc index 4646a0f9135..04766d3133d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc @@ -22,7 +22,7 @@ [% IF ( languages_loo.group_enabled ) %] [% IF ( languages_loo.plural ) %]
  • + [% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %] ([% sublanguages_loo.rfc4646_subtag | html %]) @@ -64,7 +64,7 @@ [% IF ( languages_loo.group_enabled ) %] [% IF ( languages_loo.current ) %]
  • [% ELSE %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt index 2364b24b892..cd17cee4906 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt @@ -60,7 +60,7 @@ [% END %] [% ELSE %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Interlibrary loan requests + Interlibrary loan requests [% END %] [% END %] [% END #/ WRAPPER breadcrumbs %] -- 2.39.5