From 2995b1ad9b396e159256d418f9ab36807ccde520 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= Date: Wed, 5 Nov 2025 13:49:36 -0300 Subject: [PATCH] Bug 29668: Adapt to current guidelines MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The added patches make some changes: * $c->req->json is used to access the request body, as explained by the Mojolicious OpenAPI plugin author it should be done. * Instead of calling `$basket->to_api` we use the `$c->objects->to_api` helper which deals with calling context (embeds, etc). Otherwise it would require doing it manually if embeds are added. * Tests are grouped together the same way the rest of them are. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/acquisitions_baskets.t => SUCCESS: Tests pass! Signed-off-by: Tomás Cohen Arazi Signed-off-by: Laura_Escamilla --- Koha/REST/V1/Acquisitions/Baskets.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/REST/V1/Acquisitions/Baskets.pm b/Koha/REST/V1/Acquisitions/Baskets.pm index f1f126d980..708b9b7cbc 100644 --- a/Koha/REST/V1/Acquisitions/Baskets.pm +++ b/Koha/REST/V1/Acquisitions/Baskets.pm @@ -43,14 +43,14 @@ sub add { my $c = shift->openapi->valid_input or return; return try { - my $basket = Koha::Acquisition::Basket->new_from_api( $c->validation->param('body') ); - $basket->store->discard_changes; + my $basket = Koha::Acquisition::Basket->new_from_api( $c->req->json ); + $basket->store; $c->res->headers->location( $c->req->url->to_string . '/' . $basket->basketno ); return $c->render( status => 201, - openapi => $basket->to_api + openapi => $c->objects->to_api($basket), ); } catch { $c->unhandled_exception($_); -- 2.39.5