From 5b2dd6f6e8134b0fe845f16af3e2d03d9089c122 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Thu, 6 Nov 2025 21:25:58 +0000 Subject: [PATCH] Bug 41211: Deal with findborrower in holds_table_patron_page function To test: 1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. 2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". 4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". 6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= 7. IF you go back to the patron record the hold is not cancelled. 8. APPLY PATCH and clear the browser cache. 9. Try again, eveything should work! Signed-off-by: CJ Lynce --- koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js index 551002f930..f9ec2dfb75 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -1021,7 +1021,10 @@ function toggleBtnIcon(element, start, replacement) { */ function holds_table_patron_page() { var url = window.location.href; - if (url.indexOf("/circ/circulation.pl?borrowernumber=") !== -1) + if ( + url.indexOf("/circ/circulation.pl?borrowernumber=") !== -1 || + url.indexOf("/circ/circulation.pl?findborrower=") !== -1 + ) return "circ"; else if (url.indexOf("/members/moremember.pl?borrowernumber=") !== -1) return "borrower"; -- 2.39.5