From 7751a6461c8fc3d3bfbcd9b7731dad093ade4f62 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Mon, 10 Nov 2025 04:25:35 +0000 Subject: [PATCH] Bug 31391: (follow-up) Only skip displaying recalls in messaging preference is UseRecalls syspref is off This patch includes a fix to display the two recalls notices (PICKUP_RECALLED_ITEM and RETURN_RECALLED_ITEM) added to the members messaging preferences table by bug 23781 Now those two recalls notices are always displayed in the messaging preference form, when UseRecalls is set to: opac, staff or opac_and_staff Test plan: 1. Set the UseRecalls system preference to opac, staff or opac_and_staff 2. Confirm that the 'Return recalled item' and 'Recall awaiting pickup' rows DO NOT appear in the Member (User) messaging preferences on a patron account or when editing a category 3. Apply this patch 4. Confirm that the 'Return recalled item' and 'Recall awaiting pickup' rows DO now appear in the Member (User) messaging preferences on a patron account or when editing a category Sponsored-by: Auckland University of Technology --- .../prog/en/includes/messaging-preference-form.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc index 3a16fd9b897..9ce2c850d2f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc @@ -24,7 +24,7 @@ [% NEXT IF !Koha.Preference('MembershipExpiryDaysNotice') && messaging_preference.Patron_Expiry %] [% NEXT IF messaging_preference.Patron_Expiry && (category.enforce_expiry_notice || patron.category.enforce_expiry_notice) %] [% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %] - [% NEXT IF Koha.Preference('UseRecalls') != "off" && messaging_preference.message_name.match('^Recall_') %] + [% NEXT IF Koha.Preference('UseRecalls') == "off" && messaging_preference.message_name.match('^Recall_') %] [% IF ( messaging_preference.Item_Due ) %] -- 2.39.5