From c8d85ec0dd54fa98a4f19f3d5f0b6318d779bfcf Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 3 Oct 2024 15:41:05 +0100 Subject: [PATCH] Bug 38072: Fix regression in modal_printer This patch updates the JS for the modal printer to make it more reliable. I found that in recent versions of chrome the print dialog failed to open and instead you were just faced with a flash of white before the new tab autoclosed and no print takes place. Test plan 1) Enable cash registers and point of sale preferences 2) Add a debit type and mark it as 'Can be sold' 3) Add a cash register 4) Use 'Point of sale' to sell one of the above item for cash against the register you just created. 5) Navigate to the register and 'cashup' 6) Click the 'summary' link to display a modal 7) Use the 'Print' option in the modal and confirm you face a print dialog and can print 8) The print tab should be closed and you should be back to Koha Signed-off-by: David Nind --- koha-tmpl/intranet-tmpl/prog/js/modal_printer.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/modal_printer.js b/koha-tmpl/intranet-tmpl/prog/js/modal_printer.js index ddc3b6d745..ac562c7056 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/modal_printer.js +++ b/koha-tmpl/intranet-tmpl/prog/js/modal_printer.js @@ -40,8 +40,13 @@ $(document).ready(function () { `); win.document.write(title); win.document.write(contents); + win.document.close(); + win.focus(); win.print(); - win.close(); + win.onafterprint = function () { + win.close(); + } + setTimeout('window.close()', 1000); //Hack from Chrome < 63 } // Set focused on printable modals on open and autoprint if required -- 2.39.5