From 4d3d173304a51e6fd7c6378bcba9ba5eca51b51a Mon Sep 17 00:00:00 2001 From: Caroline Cyr La Rose Date: Mon, 1 Dec 2025 16:13:05 -0500 Subject: [PATCH] Bug 40879: follow-up (change OpacCiteModal to OPACCite) This patch addresses QA comments on the new system preference name and description. --- installer/data/mysql/atomicupdate/bug_40879.pl | 4 ++-- installer/data/mysql/mandatory/sysprefs.sql | 2 +- .../prog/en/modules/admin/preferences/opac.pref | 8 ++++---- .../bootstrap/en/includes/modals/catalog_cite.inc | 2 +- .../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug_40879.pl b/installer/data/mysql/atomicupdate/bug_40879.pl index 26649b4c18b..ffb8e4c46f9 100644 --- a/installer/data/mysql/atomicupdate/bug_40879.pl +++ b/installer/data/mysql/atomicupdate/bug_40879.pl @@ -10,11 +10,11 @@ return { # Do you stuffs here $dbh->do( - q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OpacCiteModal', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo')} + q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OPACCite', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo')} ); # sysprefs - say $out "Added new system preference 'OpacCiteModal'"; + say $out "Added new system preference 'OPACCite'"; }, }; diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql index 8e80480baa1..bb8a673073a 100644 --- a/installer/data/mysql/mandatory/sysprefs.sql +++ b/installer/data/mysql/mandatory/sysprefs.sql @@ -493,7 +493,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('OpacBrowseResults','1',NULL,'Disable/enable browsing and paging search results from the OPAC detail page.','YesNo'), ('OpacBrowseSearch', '0',NULL, "Elasticsearch only: add a page allowing users to 'browse' all items in the collection",'YesNo'), ('OpacCatalogConcerns', '0', NULL, 'Allow logged in OPAC users to report catalog concerns', 'YesNo'), -('OpacCiteModal', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo'), +('OPACCite', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo'), ('OpacCloud','0',NULL,'If ON, enables subject cloud on OPAC','YesNo'), ('OpacCoce','0', NULL, 'If on, enables cover retrieval from the configured Coce server in the OPAC', 'YesNo'), ('OPACComments','1','','If ON, enables patron reviews of bibliographic records in the OPAC','YesNo'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index 18fb88a4084..047f6b113b8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -421,11 +421,11 @@ OPAC: - "patrons to browse subject authorities on the OPAC." - "
NOTE: This system preference requires the misc/cronjobs/build_browser_and_cloud.pl cronjob. Ask your system administrator to schedule it." - - - pref: OpacCiteModal + - pref: OPACCite choices: - 1: Enable - 0: Disable - - the option to show the Cite modal on the bibliographic detail page. + 1: Show + 0: "Don't show" + - the cite option on OPAC bibliographic detail pages. - - pref: OpacCloud choices: diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc index 15895d18bdf..b80efac826d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc @@ -1,5 +1,5 @@ [% USE raw %] -[% IF Koha.Preference('OpacCiteModal') %] +[% IF Koha.Preference('OPACCite') %]