From 1204d274100074318e603d5b3c691af4a9e8be51 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 5 Dec 2025 13:56:11 +0000 Subject: [PATCH] Bug 41090: Handle auto_unseen_final message on renew.pl To test: 0 - Follow previous plan, set system preference UnseenRenewals to 'Allow' 1 - Adjust circ rule for: Renewals Allowed: 3 Unseen renewals allowed: 2 Renewal period: 5 No renewal before: 6 No automatic renewal before: 6 Auto renewal: Yes 2 - Issue an item that matches that rule 3 - Use the 'Renew' tab in the toolbar or browse to Circulation->Renew 4 - Enter the item barcode 5 - You see 2 messages: Cannot renew: Item has been scheduled for automatic renewal "Continue without renewing" Item renewed.. 6 - Apply patch 7 - Check in item, and repeat 2-4 8 - Now you get a single success message and a note that the item has been renewed --- circ/renew.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/circ/renew.pl b/circ/renew.pl index 7f8ae15e671..a990f17a35e 100755 --- a/circ/renew.pl +++ b/circ/renew.pl @@ -75,6 +75,11 @@ if ( $op eq 'cud-renew' && $barcode ) { ( $can_renew, $error, $info ) = CanBookBeRenewed( $patron, $checkout, $override_limit ); push @{$confirmations}, 'RENEWAL_LIMIT' if $override_limit; + if ( $can_renew && $error && ( $error eq 'auto_renew' ) ) { + + # While scheduled for auto renewal, we are able to renew this one according to rules, so not a problem + $error = undef; + } if ( $error && ( $error eq 'auto_renew_final' ) ) { # This error implies it can be renewed - but not again after this, so no error -- 2.39.5