From 62f937a9e711f75afbf8254650b2dd56d9e71de5 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Tue, 16 Dec 2025 14:09:02 +0200 Subject: [PATCH] Bug 41454: Remove unused dbh calls Signed-off-by: Roman Dolny --- C4/Biblio.pm | 1 - C4/Circulation.pm | 1 - C4/InstallAuth.pm | 1 - C4/Search.pm | 2 -- C4/XISBN.pm | 1 - acqui/histsearch.pl | 1 - acqui/newordersuggestion.pl | 1 - authorities/authorities-home.pl | 1 - cataloguing/value_builder/marc21_linking_section.pl | 1 - cataloguing/value_builder/unimarc_field_100.pl | 2 -- cataloguing/value_builder/unimarc_field_100_authorities.pl | 2 -- cataloguing/value_builder/unimarc_field_105.pl | 1 - cataloguing/value_builder/unimarc_field_106.pl | 1 - cataloguing/value_builder/unimarc_field_110.pl | 1 - cataloguing/value_builder/unimarc_field_115a.pl | 1 - opac/opac-search-history.pl | 1 - 16 files changed, 19 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index cdfde492d6..2a16f3f792 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -2917,7 +2917,6 @@ sub ModBiblioMarc { # Clone record as it gets modified $record = $record->clone(); - my $dbh = C4::Context->dbh; my @fields = $record->fields(); my $encoding = C4::Context->preference("marcflavour"); diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 0b2b57e375..ed1a6648b8 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -431,7 +431,6 @@ sub TooMany { my $onsite_checkout = $params->{onsite_checkout} || 0; my $switch_onsite_checkout = $params->{switch_onsite_checkout} || 0; my $cat_borrower = $patron->categorycode; - my $dbh = C4::Context->dbh; # Get which branchcode we need my $branch = _GetCircControlBranch( $item, $patron ); diff --git a/C4/InstallAuth.pm b/C4/InstallAuth.pm index 7e3271dd2e..cca540388f 100644 --- a/C4/InstallAuth.pm +++ b/C4/InstallAuth.pm @@ -236,7 +236,6 @@ sub checkauth { my $type = shift; $type = 'intranet' unless $type; - my $dbh = C4::Context->dbh(); my $template_name; $template_name = "installer/auth.tt"; diff --git a/C4/Search.pm b/C4/Search.pm index 5d6f3c6e33..13de6df693 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -88,7 +88,6 @@ This function attempts to find duplicate records using a hard-coded, fairly simp sub FindDuplicate { my ($record) = @_; - my $dbh = C4::Context->dbh; my $result = TransformMarcToKoha( { record => $record } ); my $sth; my $query; @@ -1659,7 +1658,6 @@ Format results in a form suitable for passing to the template # building the HTML output for the template sub searchResults { my ( $search_context, $searchdesc, $hits, $results_per_page, $offset, $scan, $marcresults, $xslt_variables ) = @_; - my $dbh = C4::Context->dbh; my @newresults; require C4::Items; diff --git a/C4/XISBN.pm b/C4/XISBN.pm index 6777c81662..02a62dabb4 100644 --- a/C4/XISBN.pm +++ b/C4/XISBN.pm @@ -51,7 +51,6 @@ This module provides facilities for retrieving ThingISBN and XISBN content in Ko sub _get_biblio_from_xisbn { my $xisbn = shift; - my $dbh = C4::Context->dbh; my $searcher = Koha::SearchEngine::Search->new( { index => $Koha::SearchEngine::BIBLIOS_INDEX } ); my ( $errors, $results, $total_hits ) = $searcher->simple_search_compat( "nb=$xisbn", 0, 1 ); diff --git a/acqui/histsearch.pl b/acqui/histsearch.pl index 9d1e76f008..f101e08b3e 100755 --- a/acqui/histsearch.pl +++ b/acqui/histsearch.pl @@ -60,7 +60,6 @@ use Koha::DateUtils qw( dt_from_string ); my $input = CGI->new; my $do_search = $input->param('do_search') || 0; -my $dbh = C4::Context->dbh; my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { template_name => "acqui/histsearch.tt", diff --git a/acqui/newordersuggestion.pl b/acqui/newordersuggestion.pl index 02bfa2cfc3..9c9165fb74 100755 --- a/acqui/newordersuggestion.pl +++ b/acqui/newordersuggestion.pl @@ -115,7 +115,6 @@ my $link_order = $input->param('link_order'); $op = 'else' unless $op; -my $dbh = C4::Context->dbh; my ( $template, $borrowernumber, $cookie ) = get_template_and_user( { template_name => "acqui/newordersuggestion.tt", diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl index 798df8afc1..8317db247c 100755 --- a/authorities/authorities-home.pl +++ b/authorities/authorities-home.pl @@ -37,7 +37,6 @@ use Koha::XSLT::Base; use Koha::Z3950Servers; my $query = CGI->new; -my $dbh = C4::Context->dbh; my $op = $query->param('op') || ''; my $authtypecode = $query->param('authtypecode') || ''; my $authid = $query->param('authid') || ''; diff --git a/cataloguing/value_builder/marc21_linking_section.pl b/cataloguing/value_builder/marc21_linking_section.pl index 5462159680..2218c049cc 100755 --- a/cataloguing/value_builder/marc21_linking_section.pl +++ b/cataloguing/value_builder/marc21_linking_section.pl @@ -55,7 +55,6 @@ my $builder = sub { my $launcher = sub { my ($params) = @_; my $query = $params->{cgi}; - my $dbh = C4::Context->dbh; my $op = $query->param('op') // ''; # -- op could be equal to diff --git a/cataloguing/value_builder/unimarc_field_100.pl b/cataloguing/value_builder/unimarc_field_100.pl index ad3c0549c6..30e9038062 100755 --- a/cataloguing/value_builder/unimarc_field_100.pl +++ b/cataloguing/value_builder/unimarc_field_100.pl @@ -54,8 +54,6 @@ sub plugin { my $index = $input->param('index'); my $result = $input->param('result'); - my $dbh = C4::Context->dbh; - my $defaultlanguage = C4::Context->preference("UNIMARCField100Language"); $defaultlanguage = "fre" if ( !$defaultlanguage || length($defaultlanguage) != 3 ); diff --git a/cataloguing/value_builder/unimarc_field_100_authorities.pl b/cataloguing/value_builder/unimarc_field_100_authorities.pl index c8fa9b42ac..95d3925822 100755 --- a/cataloguing/value_builder/unimarc_field_100_authorities.pl +++ b/cataloguing/value_builder/unimarc_field_100_authorities.pl @@ -52,8 +52,6 @@ sub plugin { my $index = $input->param('index'); my $result = $input->param('result'); - my $dbh = C4::Context->dbh; - my $defaultlanguage = C4::Context->preference("UNIMARCField100Language"); $defaultlanguage = "fre" if ( !$defaultlanguage || length($defaultlanguage) != 3 ); diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl index 133da61f25..a920fdd398 100755 --- a/cataloguing/value_builder/unimarc_field_105.pl +++ b/cataloguing/value_builder/unimarc_field_105.pl @@ -50,7 +50,6 @@ sub plugin { my $index = $input->param('index'); my $result = $input->param('result'); - my $dbh = C4::Context->dbh; my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { template_name => "cataloguing/value_builder/unimarc_field_105.tt", diff --git a/cataloguing/value_builder/unimarc_field_106.pl b/cataloguing/value_builder/unimarc_field_106.pl index ce19338a85..ef0ea68c7a 100755 --- a/cataloguing/value_builder/unimarc_field_106.pl +++ b/cataloguing/value_builder/unimarc_field_106.pl @@ -48,7 +48,6 @@ sub plugin { my $index = $input->param('index'); my $result = $input->param('result') || q{}; - my $dbh = C4::Context->dbh; my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { template_name => "cataloguing/value_builder/unimarc_field_106.tt", diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl index 5ef09c18cb..e6c9f23940 100755 --- a/cataloguing/value_builder/unimarc_field_110.pl +++ b/cataloguing/value_builder/unimarc_field_110.pl @@ -50,7 +50,6 @@ sub plugin { my $index = $input->param('index'); my $result = $input->param('result'); - my $dbh = C4::Context->dbh; my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { template_name => "cataloguing/value_builder/unimarc_field_110.tt", diff --git a/cataloguing/value_builder/unimarc_field_115a.pl b/cataloguing/value_builder/unimarc_field_115a.pl index 1249353a78..7d9b48b27c 100755 --- a/cataloguing/value_builder/unimarc_field_115a.pl +++ b/cataloguing/value_builder/unimarc_field_115a.pl @@ -55,7 +55,6 @@ sub plugin { my $index = $input->param('index'); my $result = $input->param('result'); - my $dbh = C4::Context->dbh; my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { template_name => "cataloguing/value_builder/unimarc_field_115a.tt", diff --git a/opac/opac-search-history.pl b/opac/opac-search-history.pl index b0a853b0dc..831c819de4 100755 --- a/opac/opac-search-history.pl +++ b/opac/opac-search-history.pl @@ -97,7 +97,6 @@ unless ($loggedinuser) { } else { # And if the user is logged in, we deal with the database - my $dbh = C4::Context->dbh; # Deleting search history if ( $op eq 'cud-delete' ) { -- 2.39.5