From d279552fe9c799cc6827df6c92b869c2275f0feb Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 9 Jan 2026 12:13:30 +0100 Subject: [PATCH] Bug 41558: Fix and standardize links to tab on opac-user We have different implemented solution to select a tab on opac-user: * a "tab" variable (from bug 37972), it's never used * several variables passed from the controller to the template, depending on the tab to select (it works and is used) * use of anchors (it does not work and is used) We should fix and standardize it. I've linked to several reports that seem to conflict with each others. This patch suggests to have a "tab" variable Test plan: Confirm that the different links to tab to opac-user are not using a query parameter to pass the tab to select, e.g. from the opac-main page. --- .../en/includes/patron-restrictions.inc | 2 +- .../bootstrap/en/modules/opac-main.tt | 8 +++---- .../bootstrap/en/modules/opac-recall.tt | 2 +- .../bootstrap/en/modules/opac-user.tt | 24 ++++++++----------- opac/opac-article-request-cancel.pl | 2 +- opac/opac-modrequest-suspend.pl | 2 +- opac/opac-modrequest.pl | 2 +- opac/opac-request-article.pl | 2 +- opac/opac-reserve.pl | 2 +- opac/opac-user.pl | 23 ++++++++---------- 10 files changed, 31 insertions(+), 38 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-restrictions.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-restrictions.inc index 7b2453b7b37..5ca6ea59090 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-restrictions.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-restrictions.inc @@ -21,7 +21,7 @@ [% END %]
  • Usually the reason for freezing an account is old overdues or damage fees. If it appears that your account is clear, please contact the library. - Check your charges page. Check your overdues. + Check your charges page. Check your overdues.
  • diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt index c41dc43e9f3..84859f99d1e 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt @@ -234,7 +234,7 @@