From 0a647b78bc45b011f52f4747f6dee9180b124aa1 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 6 Jan 2026 16:40:36 +0100 Subject: [PATCH] Bug 41563: Tidy kohaTable - acqui/orderreceive.tt See bug 41324 comment 6 1. Variable serialization 2. Use of permissions and sysprefs We also removed 'UniqueItemFields' from the controller. --- acqui/orderreceive.pl | 19 +++-- .../prog/en/modules/acqui/orderreceive.tt | 69 +++++++++++-------- 2 files changed, 48 insertions(+), 40 deletions(-) diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl index ebfd813ba90..b55e8a200e1 100755 --- a/acqui/orderreceive.pl +++ b/acqui/orderreceive.pl @@ -166,16 +166,15 @@ unless ($acq_fw) { my @gst_values = map { option => $_ + 0.0 }, split( '\|', C4::Context->preference("TaxRates") ); $template->param( - freight => $freight, - name => $bookseller->name, - active_currency => $active_currency, - currencies => $currencies->search( { rate => { '!=' => 1 } } ), - invoiceincgst => $bookseller->invoiceincgst, - invoiceid => $invoice->{invoiceid}, - invoice => $invoice->{invoicenumber}, - gst_values => \@gst_values, - vendor => $bookseller, - UniqueItemFields => C4::Context->preference('UniqueItemFields'), + freight => $freight, + name => $bookseller->name, + active_currency => $active_currency, + currencies => $currencies->search( { rate => { '!=' => 1 } } ), + invoiceincgst => $bookseller->invoiceincgst, + invoiceid => $invoice->{invoiceid}, + invoice => $invoice->{invoicenumber}, + gst_values => \@gst_values, + vendor => $bookseller, ); my $patron = Koha::Patrons->find($loggedinuser)->unblessed; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt index 96844943c94..e215c034e21 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt @@ -453,6 +453,22 @@ [% INCLUDE 'datatables.inc' %] [% INCLUDE 'js-date-format.inc' %] [% INCLUDE 'format_price.inc' %] + +