From 725536726a14e0647e75b63d439e5b5646c639c4 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 20 Jan 2026 12:13:47 -0500 Subject: [PATCH] Bug 41144: Fix markup errors in self checkout and self checkin templates This patch fixes several markup errors in the self checkout and self checkin templates, for example: - Missing
s ( must be inside one) - Stray ending - Missing The patch also makes some changes to bring masthead-sci.inc and masthead-sco.inc in sync, and makes a correction to a tab WRAPPER in sco-main.tt. Unrelated: Minor markup changes to langmenu.inc in order to fix HTML validation errors. To test, apply the patch and if necessary enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Go to the self-checkout page and log in - View source and copy the markup into the validator: https://validator.w3.org/#validate-by-input - Perform the same test with the self checkin page. Sponsored-by: Athens County Public Libraries --- .../bootstrap/en/includes/langmenu.inc | 8 ++-- .../bootstrap/en/includes/masthead-sci.inc | 21 ++++++---- .../bootstrap/en/includes/masthead-sco.inc | 11 +++++- .../bootstrap/en/modules/sci/sci-main.tt | 38 ++++++++++--------- .../bootstrap/en/modules/sco/sco-main.tt | 34 ++++++++--------- 5 files changed, 65 insertions(+), 47 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc index 187c886974c..6e9001a7c4f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc @@ -6,9 +6,9 @@ [% SET menu_id = 'header_langmenu' %] [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sci.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sci.inc index 7113136a378..d5868c1497b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sci.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sci.inc @@ -5,10 +5,13 @@ [% SET OpacLangSelectorMode = Koha.Preference('OpacLangSelectorMode') %] [% SET OpacHeader = AdditionalContents.get( location => "opacheader", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %] + + + + [% IF ( Koha.Preference( 'opaclanguagesdisplay' ) && ( ! one_language_enabled ) && ( languages_loop ) && ( OpacLangSelectorMode == 'both' || OpacLangSelectorMode == 'top') ) %] + [% context = "header" %] + [% INCLUDE 'langmenu.inc' %] + [% END %] -