From ad29102228cfbd81cc8dd8562c52eacbe256ccfc Mon Sep 17 00:00:00 2001 From: Arthur Suzuki Date: Mon, 16 Dec 2024 10:59:22 +0100 Subject: [PATCH] Bug 7376: Unit test Signed-off-by: Julian Maurice Signed-off-by: Baptiste Wojtkowski Signed-off-by: Mathieu Saby Rebased-by: Victor Grousset/tuxayo --- t/db_dependent/Circulation.t | 65 ++++++++++++++++++++++++++++++------ 1 file changed, 54 insertions(+), 11 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 31f171cbbe..cdc280367b 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -19,7 +19,7 @@ use Modern::Perl; use utf8; use Test::NoWarnings; -use Test::More tests => 83; +use Test::More tests => 84; use Test::Exception; use Test::MockModule; use Test::Deep qw( cmp_deeply ); @@ -1185,7 +1185,7 @@ subtest "CanBookBeRenewed tests" => sub { ); my $ten_days_before = dt_from_string->add( days => -10 ); - my $ten_days_ahead = dt_from_string->add( days => 10 ); + my $ten_days_ahead = dt_from_string->add( days => 10 ); my $issue = AddIssue( $renewing_borrower_obj, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } @@ -1335,7 +1335,7 @@ subtest "CanBookBeRenewed tests" => sub { ); my $ten_days_before = dt_from_string->add( days => -10 ); - my $ten_days_ahead = dt_from_string->add( days => 10 ); + my $ten_days_ahead = dt_from_string->add( days => 10 ); my $issue = AddIssue( $renewing_borrower_obj, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } @@ -1445,7 +1445,7 @@ subtest "CanBookBeRenewed tests" => sub { ); my $ten_days_before = dt_from_string->add( days => -10 ); - my $ten_days_ahead = dt_from_string->add( days => 10 ); + my $ten_days_ahead = dt_from_string->add( days => 10 ); # Patron is expired and BlockExpiredPatronOpacActions='' # => auto renew is allowed @@ -1497,7 +1497,7 @@ subtest "CanBookBeRenewed tests" => sub { ); my $ten_days_before = dt_from_string->add( days => -10 ); - my $ten_days_ahead = dt_from_string->add( days => 10 ); + my $ten_days_ahead = dt_from_string->add( days => 10 ); my $issue = AddIssue( $renewing_borrower_obj, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } @@ -1618,7 +1618,7 @@ subtest "CanBookBeRenewed tests" => sub { ); my $ten_days_before = dt_from_string->add( days => -10 ); - my $ten_days_ahead = dt_from_string->add( days => 10 ); + my $ten_days_ahead = dt_from_string->add( days => 10 ); my $issue = AddIssue( $renewing_borrower_obj, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } @@ -1969,7 +1969,7 @@ subtest "GetUpcomingDueIssues" => sub { my $a_borrower = Koha::Patrons->find($a_borrower_borrowernumber); my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 ); - my $two_days_ahead = DateTime->today( time_zone => C4::Context->tz() )->add( days => 2 ); + my $two_days_ahead = DateTime->today( time_zone => C4::Context->tz() )->add( days => 2 ); my $today = DateTime->today( time_zone => C4::Context->tz() ); my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday ); @@ -2846,6 +2846,49 @@ subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub { ); }; +subtest 'CanBookBeReturned + UseBranchTransfertLimits' => sub { + plan tests => 6; + + my $homebranch = $builder->build( { source => 'Branch' } ); + my $otherbranch = $builder->build( { source => 'Branch' } ); + my $patron = + $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } ); + + my $item = $builder->build_sample_item( + { + homebranch => $homebranch->{branchcode}, + holdingbranch => $homebranch->{branchcode}, + } + ); + + t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' ); + set_userenv($homebranch); + my $issue = AddIssue( $patron, $item->barcode ); + my ( $allowed, $message ) = C4::Circulation::CanBookBeReturned( $item, $otherbranch ); + is( 1, $allowed, 'with AllowReturnToBranch = anywhere and no limits return to other is allowed' ); + is( undef, $message, 'without limits provides no message' ); + + t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '1' ); + t::lib::Mocks::mock_preference( 'BranchTransferLimitsType', 'itemtype' ); + + # set limit + my $limit = Koha::Item::Transfer::Limit->new( + { + toBranch => $otherbranch->{branchcode}, + fromBranch => $item->homebranch, + itemtype => $item->effective_itemtype, + } + )->store(); + + ( $allowed, $message ) = C4::Circulation::CanBookBeReturned( $item, $otherbranch ); + is( 0, $allowed, 'With transfer limits cannot return to otherbranch' ); + is( $homebranch->{branchcode}, $message, 'With transfer limits asks return to homebranch' ); + + ( $allowed, $message ) = C4::Circulation::CanBookBeReturned( $item, $homebranch ); + is( 1, $allowed, 'With transfer limits can return to homebranch' ); + is( undef, $message, 'With transfer limits and homebranch provides no message' ); +}; + subtest 'Statistic patrons "X"' => sub { plan tests => 15; @@ -3881,7 +3924,7 @@ subtest 'AddReturn | is_overdue' => sub { is( $line->status, 'RETURNED', "Overdue fine is fixed" ); $line = $lines->next; is( $line->amount + 0, -2, "Original payment amount remains as 2" ); - is( $line->amountoutstanding + 0, 0, "Original payment remains applied" ); + is( $line->amountoutstanding + 0, 0, "Original payment remains applied" ); $line = $lines->next; is( $line->amount + 0, -1, "Refund amount correctly set to 1" ); is( $line->amountoutstanding + 0, -1, "Refund amount outstanding unspent" ); @@ -4835,7 +4878,7 @@ subtest '_FixOverduesOnReturn' => sub { my $credit = $offset->credit; is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" ); is( $credit->amount + 0, -99, "Credit amount is set correctly" ); - is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" ); + is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" ); # Bug 25417 - Only forgive fines where there is an amount outstanding to forgive $accountline->set( @@ -7586,7 +7629,7 @@ subtest 'NoRefundOnLostFinesPaidAge' => sub { { borrowernumber => $patron->id, date => '1970-01-01 14:00:01', - amountoutstanding => 0, + amountoutstanding => 0, amount => -5, interface => 'commandline', credit_type_code => 'PAYMENT' @@ -7642,7 +7685,7 @@ subtest 'NoRefundOnLostFinesPaidAge' => sub { borrowernumber => $patron2->id, date => '1970-01-01 14:00:01', amount => -5, - amountoutstanding => 0, + amountoutstanding => 0, interface => 'commandline', credit_type_code => 'PAYMENT' } -- 2.52.0