From 6065cce0aeefb722b23d25a6a290d2d1b9be386a Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 26 Jan 2026 16:11:34 +0000 Subject: [PATCH] Bug 41182: Unit tests --- .../Koha/ERM/EUsage/UsageDataProvider.t | 36 ++++++++++++++++--- 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t index ac82a0cd521..5d2c658256a 100755 --- a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t +++ b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t @@ -32,7 +32,7 @@ my $builder = t::lib::TestBuilder->new; subtest '_build_url_query' => sub { - plan tests => 3; + plan tests => 4; $schema->storage->txn_begin; @@ -47,10 +47,14 @@ subtest '_build_url_query' => sub { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, - customer_id => $customer_id, name => $name, service_platform => undef, report_release => 5 + customer_id => $customer_id, name => $name, service_platform => undef, report_release => 5, + dateformat => undef, } } ); + $usage_data_provider->discard_changes; + + # When date format is not specified we will use YYYY-MM date in the url $usage_data_provider->{report_type} = 'TR_J1'; $usage_data_provider->{begin_date} = '2023-08-01'; @@ -80,7 +84,8 @@ subtest '_build_url_query' => sub { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, - customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => 5 + customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => 5, + dateformat => 'yyyy-mm', } } ); @@ -113,7 +118,8 @@ subtest '_build_url_query' => sub { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, - customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => '5.1' + customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => '5.1', + dateformat => 'yyyy-mm', } } ); @@ -141,6 +147,28 @@ subtest '_build_url_query' => sub { . $test_platform ); + $usage_data_provider_51->dateformat('yyyy-mm-dd')->store(); + + is( + $usage_data_provider_51->_build_url_query, + $service_url + . '/r51/reports/' + . lc( $usage_data_provider->{report_type} ) + . '?customer_id=' + . $customer_id + . '&requestor_id=' + . $requestor_id + . '&api_key=' + . $api_key + . '&begin_date=' + . substr( $usage_data_provider->{begin_date}, 0, 10 ) + . '&end_date=' + . substr( $usage_data_provider->{end_date}, 0, 10 ) + . '&platform=' + . $test_platform, + "When date format is set to YYYY-MM-DD we send date in that format" + ); + $schema->storage->txn_rollback; }; -- 2.39.5