From b5b12a07daaa8fccbb2c24ff8cd928da9913cee5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 26 Jan 2026 11:09:33 +0100 Subject: [PATCH] Bug 41710: Correctly run tests SearchEngine/Elasticsearch/Search.t in a txn Test plan: 0. Apply this patch and startup ktd with elastic (e.g `--search-engine es7`) 1. prove t/db_dependent/check_sysprefs.t => pass 2. DB cli> SELECT COUNT(*) FROM systempreferences; 3. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4. DB cli> SELECT COUNT(*) FROM systempreferences; => No change, still the same number of sysprefs 5. prove t/db_dependent/check_sysprefs.t => pass 6. Revert this patch or checkout main 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 8. DB cli> SELECT COUNT(*) FROM systempreferences; => One syspref crated (ElasticsearchIndexStatus_mydb) 9. prove t/db_dependent/check_sysprefs.t => fail Signed-off-by: David Nind Signed-off-by: Lucas Gass --- t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t index 42d2efd588e..b1cbc3ff78d 100755 --- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t +++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t @@ -26,6 +26,9 @@ use Koha::SearchEngine::Elasticsearch::QueryBuilder; use Koha::SearchEngine::Elasticsearch::Indexer; use Koha::SearchFields; +my $schema = Koha::Database->new()->schema(); +$schema->storage->txn_begin; + my $se = Test::MockModule->new('Koha::SearchEngine::Elasticsearch'); $se->mock( 'get_elasticsearch_mappings', @@ -123,7 +126,6 @@ SKIP: { subtest "_convert_facets" => sub { plan tests => 5; - my $schema = Koha::Database->new()->schema(); $schema->storage->txn_begin; my $builder = t::lib::TestBuilder->new; -- 2.39.5