From 1b24376be84b4d4a2834b2d91d64a81a0d555848 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 28 Nov 2023 13:30:45 +0000 Subject: [PATCH] Bug 23260: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Peter Moore --- t/db_dependent/Koha/Patrons.t | 192 +++++++++++++++++++++++++++++++--- 1 file changed, 180 insertions(+), 12 deletions(-) diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t index 6dad68f2893..6b0734df993 100755 --- a/t/db_dependent/Koha/Patrons.t +++ b/t/db_dependent/Koha/Patrons.t @@ -20,7 +20,7 @@ use Modern::Perl; use Test::NoWarnings; -use Test::More tests => 48; +use Test::More tests => 49; use Test::Warn; use Test::Exception; use Test::MockModule; @@ -502,7 +502,8 @@ subtest 'renew_account' => sub { ); my $number_of_logs = $schema->resultset('ActionLog') - ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count; + ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } ) + ->count; is( $number_of_logs, 1, 'With BorrowersLog, Koha::Patron->renew_account should have logged' ); t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'now' ); @@ -518,7 +519,8 @@ subtest 'renew_account' => sub { is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" ); $number_of_logs = $schema->resultset('ActionLog') - ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count; + ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } ) + ->count; is( $number_of_logs, 1, 'Without BorrowersLog, Koha::Patron->renew_account should not have logged' ); t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' ); @@ -654,7 +656,8 @@ subtest "delete" => sub { my $number_of_logs = $schema->resultset('ActionLog') - ->search( { module => 'MEMBERS', action => 'DELETE', object => $patron->borrowernumber } )->count; + ->search( { module => 'MEMBERS', action => 'DELETE', object => $patron->borrowernumber } ) + ->count; is( $number_of_logs, 1, 'With BorrowersLog, Koha::Patron->delete should have logged' ); # Test deletion with designated fallback owner @@ -727,7 +730,8 @@ subtest 'add_enrolment_fee_if_needed' => sub { foreach ( keys %{$enrolmentfees} ) { ( Koha::Patron::Categories->find($_) // $builder->build_object( { class => 'Koha::Patron::Categories', value => { categorycode => $_ } } ) ) - ->enrolmentfee( $enrolmentfees->{$_} )->store; + ->enrolmentfee( $enrolmentfees->{$_} ) + ->store; } my $enrolmentfee_K = $enrolmentfees->{K}; my $enrolmentfee_J = $enrolmentfees->{J}; @@ -1547,6 +1551,165 @@ subtest 'search_patrons_to_anonymise' => sub { t::lib::Mocks::mock_preference( 'IndependentBranches', 0 ); }; +subtest 'anonymize items_last_borrower' => sub { + plan tests => 2; + + my $anonymous = $builder->build_object( { class => 'Koha::Patrons', }, ); + + t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous->borrowernumber ); + t::lib::Mocks::mock_preference( 'StoreLastBorrower', 1 ); + t::lib::Mocks::mock_preference( 'AnonymizeLastBorrower', 1 ); + + subtest 'anonymize items_last_borrower by days' => sub { + plan tests => 4; + + t::lib::Mocks::mock_preference( 'AnonymizeLastBorrowerDays', 5 ); + + my $patron = $builder->build_object( + { + class => 'Koha::Patrons', + value => { privacy => 1, } + } + ); + my $item_1 = $builder->build_sample_item; + my $issue_1 = $builder->build_object( + { + class => 'Koha::Checkouts', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_1->itemnumber, + }, + } + ); + my $item_2 = $builder->build_sample_item; + my $issue_2 = $builder->build_object( + { + class => 'Koha::Checkouts', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_2->itemnumber, + }, + } + ); + + my $dbh = C4::Context->dbh; + my ($returned_1) = C4::Circulation::AddReturn( $item_1->barcode, undef, undef, dt_from_string ); + my ($returned_2) = C4::Circulation::AddReturn( $item_2->barcode, undef, undef, dt_from_string ); + is( $returned_1 && $returned_2, 1, 'The items should have been returned' ); + my $stu = $dbh->prepare(q|UPDATE items_last_borrower set created_on = ? where itemnumber = ?|); + $stu->execute( DateTime->today( time_zone => C4::Context->tz() )->add( days => -6 ), $item_2->itemnumber ); + + my $nb_rows = Koha::Patrons->anonymize_last_borrowers(); + is( $nb_rows, 1, 'anonymize_last_borrowers should have returned the number of last borrowers anonymized' ); + + my $sth = $dbh->prepare(q|SELECT borrowernumber FROM items_last_borrower where itemnumber = ?|); + $sth->execute( $item_1->itemnumber ); + my ($borrowernumber_used_to_anonymize) = $sth->fetchrow_array; + is( + $borrowernumber_used_to_anonymize, $patron->borrowernumber, + 'Last borrower less than 5 days old are not anonymized' + ); + $sth->execute( $item_2->itemnumber ); + ($borrowernumber_used_to_anonymize) = $sth->fetchrow_array; + is( + $borrowernumber_used_to_anonymize, $anonymous->borrowernumber, + 'Last borrower older than 5 days are anonymized' + ); + + }; + + subtest 'withrawn, lost and damaged items' => sub { + plan tests => 6; + + t::lib::Mocks::mock_preference( 'AnonymizeLastBorrowerDays', 0 ); + + my $patron = $builder->build_object( + { + class => 'Koha::Patrons', + value => { privacy => 1, } + } + ); + my $item_1 = $builder->build_sample_item; + my $issue_1 = $builder->build_object( + { + class => 'Koha::Checkouts', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_1->itemnumber, + }, + } + ); + my $item_2 = $builder->build_sample_item; + my $issue_2 = $builder->build_object( + { + class => 'Koha::Checkouts', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_2->itemnumber, + }, + } + ); + my $item_3 = $builder->build_sample_item; + my $issue_3 = $builder->build_object( + { + class => 'Koha::Checkouts', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_3->itemnumber, + }, + } + ); + my $item_4 = $builder->build_sample_item; + my $issue_4 = $builder->build_object( + { + class => 'Koha::Checkouts', + value => { + borrowernumber => $patron->borrowernumber, + itemnumber => $item_4->itemnumber, + }, + } + ); + + my ($returned_1) = C4::Circulation::AddReturn( $item_1->barcode, undef, undef, dt_from_string('2010-10-11') ); + my ($returned_2) = C4::Circulation::AddReturn( $item_2->barcode, undef, undef, dt_from_string('2010-10-11') ); + my ($returned_3) = C4::Circulation::AddReturn( $item_3->barcode, undef, undef, dt_from_string('2010-10-11') ); + my ($returned_4) = C4::Circulation::AddReturn( $item_4->barcode, undef, undef, dt_from_string('2010-10-11') ); + is( $returned_1 && $returned_2 && $returned_3 && $returned_4, 1, 'The items should have been returned' ); + $item_1->withdrawn(1)->store; + $item_2->itemlost(1)->store; + $item_3->damaged(1)->store; + + my $dbh = C4::Context->dbh; + my $stu = $dbh->prepare(q|UPDATE items_last_borrower set created_on = ? where itemnumber in (?, ?, ?, ?)|); + $stu->execute( + DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 ), $item_1->itemnumber, + $item_2->itemnumber, $item_3->itemnumber, $item_4->itemnumber + ); + + my $nb_rows = Koha::Patrons->anonymize_last_borrowers(); + is( $nb_rows, 1, 'anonymise_last_borrowers should have returned the number of last borrowers anonymized' ); + + my $sth = $dbh->prepare(q|SELECT borrowernumber FROM items_last_borrower where itemnumber = ?|); + $sth->execute( $item_1->itemnumber ); + my ($borrowernumber_used_to_anonymize) = $sth->fetchrow_array; + is( $borrowernumber_used_to_anonymize, $patron->borrowernumber, 'withrawn items should not be anonymized' ); + $sth->execute( $item_2->itemnumber ); + ($borrowernumber_used_to_anonymize) = $sth->fetchrow_array; + is( $borrowernumber_used_to_anonymize, $patron->borrowernumber, 'lost items should not be anonymized' ); + $sth->execute( $item_3->itemnumber ); + ($borrowernumber_used_to_anonymize) = $sth->fetchrow_array; + is( $borrowernumber_used_to_anonymize, $patron->borrowernumber, 'damaged items should not be anonymized' ); + $sth->execute( $item_4->itemnumber ); + ($borrowernumber_used_to_anonymize) = $sth->fetchrow_array; + is( + $borrowernumber_used_to_anonymize, $anonymous->borrowernumber, + 'not withdrawn, lost or damaged items are anonymized' + ); + + }; + +}; + subtest 'libraries_where_can_see_patrons + libraries_where_can_see_things + can_see_patron_infos + search_limited+ can_see_patrons_from + can_edit_items_from' => sub { @@ -2475,7 +2638,8 @@ subtest '->set_password' => sub { my $number_of_logs = $schema->resultset('ActionLog') - ->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count; + ->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } ) + ->count; is( $number_of_logs, 0, 'Without BorrowersLog, Koha::Patron->set_password doesn\'t log password changes' ); # Enable logging password changes @@ -3005,8 +3169,8 @@ subtest "search_patrons_to_update_category tests" => sub { class => 'Koha::Patrons', value => { categorycode => $category_code, - dateofbirth => - $current_dt->clone->subtract( years => $category->upperagelimit + 1 )->subtract( days => 1 ) + dateofbirth => $current_dt->clone->subtract( years => $category->upperagelimit + 1 ) + ->subtract( days => 1 ) ->ymd, } } @@ -3456,7 +3620,8 @@ subtest 'filter_by_have_permission' => sub { is_deeply( [ Koha::Patrons->search( { branchcode => $library->branchcode } ) - ->filter_by_have_permission('suggestions.suggestions_manage')->get_column('borrowernumber') + ->filter_by_have_permission('suggestions.suggestions_manage') + ->get_column('borrowernumber') ], [ $patron_1->borrowernumber, $patron_2->borrowernumber ], 'Superlibrarian and patron with suggestions.suggestions_manage' @@ -3465,7 +3630,8 @@ subtest 'filter_by_have_permission' => sub { is_deeply( [ Koha::Patrons->search( { branchcode => $library->branchcode } ) - ->filter_by_have_permission('acquisition.order_manage')->get_column('borrowernumber') + ->filter_by_have_permission('acquisition.order_manage') + ->get_column('borrowernumber') ], [ $patron_1->borrowernumber, $patron_3->borrowernumber ], 'Superlibrarian and patron with acquisition.order_manage' @@ -3474,7 +3640,8 @@ subtest 'filter_by_have_permission' => sub { is_deeply( [ Koha::Patrons->search( { branchcode => $library->branchcode } ) - ->filter_by_have_permission('parameters.manage_cities')->get_column('borrowernumber') + ->filter_by_have_permission('parameters.manage_cities') + ->get_column('borrowernumber') ], [ $patron_1->borrowernumber ], 'Only Superlibrarian is returned' @@ -3482,7 +3649,8 @@ subtest 'filter_by_have_permission' => sub { is_deeply( [ - Koha::Patrons->search( { branchcode => $library->branchcode } )->filter_by_have_permission('suggestions') + Koha::Patrons->search( { branchcode => $library->branchcode } ) + ->filter_by_have_permission('suggestions') ->get_column('borrowernumber') ], [ $patron_1->borrowernumber, $patron_2->borrowernumber ], -- 2.39.5