From 556b9250a760252cbc456807d7cbe939f0f9221f Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 26 Jun 2013 16:40:09 -0400 Subject: [PATCH] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the "do not notify" checkbox is then checked 5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well 6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present --- .../prog/en/includes/messaging-preference-form.inc | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc index ed6b067..367969d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc @@ -7,6 +7,7 @@ newid = Number(rowid.replace("none","")) $("#sms"+newid).removeAttr("checked"); $("#email"+newid).removeAttr("checked"); + $("#phone"+newid).removeAttr("checked"); $("#digest"+newid).removeAttr("checked"); $("#rss"+newid).removeAttr("checked"); } @@ -99,12 +100,12 @@ + value="phone" checked="checked" onclick = "$('#none'+'[% messaging_preference.message_attribute_id %]').removeAttr('checked','');" /> [% ELSE %] + value="phone" onclick = "$('#none'+'[% messaging_preference.message_attribute_id %]').removeAttr('checked','');" /> [% END %] [% END %] [% END %] -- 1.7.2.5