From 9882eefbd6932fe99676a1c45954de66d6eecfb5 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 5 Feb 2026 08:11:14 +0000 Subject: [PATCH] Bug 35612: (QA follow-up) Use interface parameter and remove self-referential use This patch fixes two issues: 1. C4::Accounts::chargelostitem now properly uses the $interface variable that was set from $opts->{interface} instead of calling C4::Context->interface directly. This ensures the interface parameter is honored, particularly important for cronjob context. 2. Removes the self-referential 'use Koha::Checkout;' statement in Koha/Checkout.pm which is logically incorrect (a module should not use itself). Test plan: 1. Run prove t/db_dependent/Accounts.t 2. Run prove t/db_dependent/Koha/Checkout.t 3. Verify all tests pass --- C4/Accounts.pm | 4 ++-- Koha/Checkout.pm | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/C4/Accounts.pm b/C4/Accounts.pm index b9c19a4adc7..6d8208980be 100644 --- a/C4/Accounts.pm +++ b/C4/Accounts.pm @@ -140,7 +140,7 @@ sub chargelostitem { description => $description, note => $processingfeenote, user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef, - interface => C4::Context->interface, + interface => $interface, library_id => $library_id, type => 'PROCESSING', item_id => $itemnumber, @@ -157,7 +157,7 @@ sub chargelostitem { description => $description, note => undef, user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef, - interface => C4::Context->interface, + interface => $interface, library_id => $library_id, type => 'LOST', item_id => $itemnumber, diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm index 967b199a55d..63d657a67e6 100644 --- a/Koha/Checkout.pm +++ b/Koha/Checkout.pm @@ -24,7 +24,6 @@ use DateTime; use Try::Tiny qw( catch try ); use C4::Circulation qw( AddRenewal CanBookBeRenewed LostItem MarkIssueReturned ); -use Koha::Checkout; use Koha::Booking; use Koha::Checkouts::Renewals; use Koha::Checkouts::ReturnClaims; -- 2.52.0