From e5822b979755dc5c62524f89db04eb1a33f6651b Mon Sep 17 00:00:00 2001 From: Arthur Suzuki Date: Thu, 5 Feb 2026 19:40:57 +0000 Subject: [PATCH] Bug 41768: make pickup_locations endpoints public Sponsored-by BibLibre --- api/v1/swagger/paths/biblios.yaml | 5 +---- api/v1/swagger/paths/holds.yaml | 5 +---- api/v1/swagger/paths/items.yaml | 5 +---- api/v1/swagger/swagger.yaml | 12 ++++++------ 4 files changed, 9 insertions(+), 18 deletions(-) diff --git a/api/v1/swagger/paths/biblios.yaml b/api/v1/swagger/paths/biblios.yaml index 18120c5dd98..3b21e633721 100644 --- a/api/v1/swagger/paths/biblios.yaml +++ b/api/v1/swagger/paths/biblios.yaml @@ -662,7 +662,7 @@ x-koha-authorization: permissions: editcatalogue: edit_items -"/biblios/{biblio_id}/pickup_locations": +"/public/biblios/{biblio_id}/pickup_locations": get: x-mojo-to: Biblios#pickup_locations operationId: getBiblioPickupLocations @@ -723,9 +723,6 @@ description: Under maintenance schema: $ref: "../swagger.yaml#/definitions/error" - x-koha-authorization: - permissions: - reserveforothers: place_holds "/public/biblios/{biblio_id}": get: x-mojo-to: Biblios#get_public diff --git a/api/v1/swagger/paths/holds.yaml b/api/v1/swagger/paths/holds.yaml index dcd6413c03a..bbdc3202d2f 100644 --- a/api/v1/swagger/paths/holds.yaml +++ b/api/v1/swagger/paths/holds.yaml @@ -764,7 +764,7 @@ x-koha-authorization: permissions: reserveforothers: place_holds -"/holds/{hold_id}/pickup_locations": +"/public/holds/{hold_id}/pickup_locations": get: x-mojo-to: Holds#pickup_locations operationId: getHoldPickupLocations @@ -829,9 +829,6 @@ description: Under maintenance schema: $ref: "../swagger.yaml#/definitions/error" - x-koha-authorization: - permissions: - reserveforothers: place_holds "/holds/{hold_id}/pickup_location": put: x-mojo-to: Holds#update_pickup_location diff --git a/api/v1/swagger/paths/items.yaml b/api/v1/swagger/paths/items.yaml index 5acc18ad283..6ecf1e963d9 100644 --- a/api/v1/swagger/paths/items.yaml +++ b/api/v1/swagger/paths/items.yaml @@ -408,7 +408,7 @@ x-koha-authorization: permissions: circulation: 1 -"/items/{item_id}/pickup_locations": +"/public/items/{item_id}/pickup_locations": get: x-mojo-to: Items#pickup_locations operationId: getItemPickupLocations @@ -470,9 +470,6 @@ description: Under maintenance schema: $ref: "../swagger.yaml#/definitions/error" - x-koha-authorization: - permissions: - reserveforothers: place_holds "/public/items": get: x-mojo-to: Items#list_public diff --git a/api/v1/swagger/swagger.yaml b/api/v1/swagger/swagger.yaml index 9a9b7af7565..de927a815b2 100644 --- a/api/v1/swagger/swagger.yaml +++ b/api/v1/swagger/swagger.yaml @@ -289,8 +289,6 @@ paths: $ref: "./paths/biblios.yaml#/~1biblios~1{biblio_id}~1items" "/biblios/{biblio_id}/items/{item_id}": $ref: "./paths/biblios.yaml#/~1biblios~1{biblio_id}~1items~1{item_id}" - "/biblios/{biblio_id}/pickup_locations": - $ref: "./paths/biblios.yaml#/~1biblios~1{biblio_id}~1pickup_locations" "/biblios/{biblio_id}/item_groups": $ref: "./paths/biblios_item_groups.yaml#/~1biblios~1{biblio_id}~1item_groups" "/biblios/{biblio_id}/item_groups/{item_group_id}": @@ -431,8 +429,6 @@ paths: $ref: "./paths/holds.yaml#/~1holds~1{hold_id}" "/holds/{hold_id}/pickup_location": $ref: "./paths/holds.yaml#/~1holds~1{hold_id}~1pickup_location" - "/holds/{hold_id}/pickup_locations": - $ref: "./paths/holds.yaml#/~1holds~1{hold_id}~1pickup_locations" "/holds/{hold_id}/priority": $ref: "./paths/holds.yaml#/~1holds~1{hold_id}~1priority" "/holds/{hold_id}/suspension": @@ -471,8 +467,6 @@ paths: $ref: ./paths/items.yaml#/~1items~1{item_id}~1bundled_items "/items/{item_id}/bundled_items/{bundled_item_id}": $ref: ./paths/items.yaml#/~1items~1{item_id}~1bundled_items~1{bundled_item_id} - "/items/{item_id}/pickup_locations": - $ref: "./paths/items.yaml#/~1items~1{item_id}~1pickup_locations" /jobs: $ref: ./paths/jobs.yaml#/~1jobs "/jobs/{job_id}": @@ -555,6 +549,12 @@ paths: $ref: ./paths/checkouts.yaml#/~1public~1checkouts~1availability "/public/items": $ref: "./paths/items.yaml#/~1public~1items" + "/public/items/{item_id}/pickup_locations": + $ref: "./paths/items.yaml#/~1public~1items~1{item_id}~1pickup_locations" + "/public/holds/{hold_id}/pickup_locations": + $ref: "./paths/holds.yaml#/~1public~1holds~1{hold_id}~1pickup_locations" + "/public/biblios/{biblio_id}/pickup_locations": + $ref: "./paths/biblios.yaml#/~1public~1biblios~1{biblio_id}~1pickup_locations" "/public/biblios/{biblio_id}/items": $ref: "./paths/biblios.yaml#/~1public~1biblios~1{biblio_id}~1items" "/public/biblios/{biblio_id}/ratings": -- 2.39.5