From 6a12d484e824952e70453442d498cbcd1e726735 Mon Sep 17 00:00:00 2001 From: Ayoub Glizi-Vicioso Date: Fri, 23 Jan 2026 15:20:28 -0500 Subject: [PATCH] Bug 41689: Make patron message labels translatable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To Test: BEFORE APPLYING PATCH: 1- Go to any patron account > Add message 2- Add a message for: "Staff - Internal note" 3- Add a second message for: "OPAC - [NAME OF THE PATRON SELECTED]" 4- Add any language (I'll use french-Canada, fr-CA, in this case): From your koha instance, enter on the command line: ./misc/translator/translate install fr-CA 5- Go to Administration > System preferences > enter language 6- Make sure to check 'Français (fr-CA)' box from the 'StaffInterfaceLanguages'preference and save. 7- Go back to the specific patron in which you added the messages 8- Switch language to 'Français' (bottom left corner) 9- Notice that: --> 'OPAC' is still the same (Since we spell OPAC the same way in both english and french. However, it might not be the case in other languages). --> 'Staff note' is not translated. 10- apply patch AFTER APPLYING PATCH: 11 - From you koha instance, enter on the command line: ./misc/translator/translate update fr-CA ./misc/translator/translate install fr-CA 12- Reload patron's page 13- Notice that 'Staff note' is now translated ** You should see this output: 'Note interne' Signed-off-by: David Nind Signed-off-by: Katrin Fischer --- .../prog/en/includes/patron_messages.inc | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc index e661464b4a5..dbabcef9aa4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc @@ -329,20 +329,24 @@ [% FOREACH patron_message IN patron_messages %]
  • [% SET span_class = '' %] - [% SET msg_type = 'OPAC' %] - [% IF(patron_message.message_type == "L") %] + [% IF patron_message.message_type == "L" %] [% span_class = 'circ-hlt' %] - [% msg_type = 'Staff note' %] [% END %] [% patron_message.message_date | $KohaDates %] - [% Branches.GetName( patron_message.branchcode ) | html %] - - [% t(msg_type) | html %] + [% Branches.GetName(patron_message.branchcode) | html %] + - + [% IF patron_message.message_type == 'L' %] + Staff note + [% ELSE %] + OPAC + [% END %] + [% IF patron_message.manager_id %] ( - [% patron_message.get_column('manager_firstname') | html %] [% patron_message.get_column('manager_surname') | html %] + + [% patron_message.get_column('manager_firstname') | html %] [% patron_message.get_column('manager_surname') | html %] + ) [% END %] "[% patron_message.message | html | html_line_break %]" -- 2.39.5