From 9624432f1d7ddeaa447d22acf67870e9281de93b Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 23 Jan 2026 10:31:32 +0100 Subject: [PATCH] Bug 41521: Fix forbidden patterns (trailing spaces and http) Signed-off-by: Victor Grousset/tuxayo --- lib/WebService/ILS.pm | 4 ++-- lib/WebService/ILS/OverDrive.pm | 4 ++-- lib/WebService/ILS/OverDrive/Patron.pm | 6 +++--- lib/WebService/ILS/RecordedBooks.pm | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/WebService/ILS.pm b/lib/WebService/ILS.pm index 4813964e2e..8a380fd603 100644 --- a/lib/WebService/ILS.pm +++ b/lib/WebService/ILS.pm @@ -408,11 +408,11 @@ An example: client_id => $client_id, client_secret => $client_secret, }); - my $redirect_url = $ils->auth_url("http://myapp.com/ils-auth"); + my $redirect_url = $ils->auth_url("https://myapp.com/ils-auth"); $response->redirect($redirect_url); ... After successful authentication at the provider, provider redirects - back to specified app url (http://myapp.com/ils-auth) + back to specified app url (https://myapp.com/ils-auth) /ils-auth handler: my $auth_token = $req->param( $ils->auth_token_param_name ) diff --git a/lib/WebService/ILS/OverDrive.pm b/lib/WebService/ILS/OverDrive.pm index bec58af19a..963484c896 100644 --- a/lib/WebService/ILS/OverDrive.pm +++ b/lib/WebService/ILS/OverDrive.pm @@ -34,8 +34,8 @@ use parent qw(WebService::ILS::JSON); use constant API_VERSION => "v1"; -use constant DISCOVERY_API_URL => "http://api.overdrive.com/"; -use constant TEST_DISCOVERY_API_URL => "http://integration.api.overdrive.com/"; +use constant DISCOVERY_API_URL => "https://api.overdrive.com/"; +use constant TEST_DISCOVERY_API_URL => "https://integration.api.overdrive.com/"; =head1 CONSTRUCTOR diff --git a/lib/WebService/ILS/OverDrive/Patron.pm b/lib/WebService/ILS/OverDrive/Patron.pm index dacaf67e69..e1726b39cd 100644 --- a/lib/WebService/ILS/OverDrive/Patron.pm +++ b/lib/WebService/ILS/OverDrive/Patron.pm @@ -31,8 +31,8 @@ use Data::Dumper; use parent qw(WebService::ILS::OverDrive); -use constant CIRCULATION_API_URL => "http://patron.api.overdrive.com/"; -use constant TEST_CIRCULATION_API_URL => "http://integration-patron.api.overdrive.com/"; +use constant CIRCULATION_API_URL => "https://patron.api.overdrive.com/"; +use constant TEST_CIRCULATION_API_URL => "https://integration-patron.api.overdrive.com/"; use constant OAUTH_BASE_URL => "https://oauth.overdrive.com/"; use constant TOKEN_URL => OAUTH_BASE_URL . 'token'; use constant AUTH_URL => OAUTH_BASE_URL . 'auth'; @@ -123,7 +123,7 @@ An example: client_secret => $client_secret, library_id => $library_id, }); - my $redirect_url = $overdrive->auth_url("http://myapp.com/overdrive-auth"); + my $redirect_url = $overdrive->auth_url("https://myapp.com/overdrive-auth"); $response->redirect($redirect_url); ... /overdrive-auth handler: diff --git a/lib/WebService/ILS/RecordedBooks.pm b/lib/WebService/ILS/RecordedBooks.pm index 0e827a809c..c8f66811f5 100644 --- a/lib/WebService/ILS/RecordedBooks.pm +++ b/lib/WebService/ILS/RecordedBooks.pm @@ -639,7 +639,7 @@ sub native_item_summary { =head2 native_holds () -See L +See L =cut -- 2.53.0