From a86d458aa156abd01b1fe40eb9669e9b5b5f149c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 9 Feb 2026 11:35:00 +0100 Subject: [PATCH] Bug 41624: Simplify db rev Also fix QA failures: [FAIL] installer/data/mysql/atomicupdate/bug_41624.pl FAIL file_permissions File must have the exec flag FAIL forbidden_patterns forbidden pattern: trailing space char (line 13) Signed-off-by: Jonathan Druart --- .../data/mysql/atomicupdate/bug_41624.pl | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug_41624.pl diff --git a/installer/data/mysql/atomicupdate/bug_41624.pl b/installer/data/mysql/atomicupdate/bug_41624.pl old mode 100644 new mode 100755 index 4387a7f683a..3b9afec4b6b --- a/installer/data/mysql/atomicupdate/bug_41624.pl +++ b/installer/data/mysql/atomicupdate/bug_41624.pl @@ -8,24 +8,11 @@ return { my ($args) = @_; my ( $dbh, $out ) = @$args{qw(dbh out)}; - # Check if the preference exists before removing - my ($exists) = $dbh->selectrow_array( + $dbh->do( q{ - SELECT COUNT(*) - FROM systempreferences + DELETE FROM systempreferences WHERE variable = 'SeparateHoldingsByGroup' } - ); - - if ($exists) { - $dbh->do( - q{ - DELETE FROM systempreferences - WHERE variable = 'SeparateHoldingsByGroup' - } - ); - } - - say_success( $out, "Removed system preference 'SeparateHoldingsByGroup'" ); + ) != '0E0' && say_success( $out, "Removed system preference 'SeparateHoldingsByGroup'" ); }, }; -- 2.43.0