From 238275a7f816ce6ab61db42efe894b6fc835f2f5 Mon Sep 17 00:00:00 2001 From: Paul Derscheid Date: Mon, 9 Feb 2026 15:25:34 +0100 Subject: [PATCH] Bug 37707: (QA follow-up) Fix incorrect bold date expectations in Cypress test - The test for circulation rules date calculations did not account for the start date being bold, only the period endpoint dates - place_booking.js explicitly adds the selected start date to boldDates (boldDates = [new Date(startDate)]), giving it the "title" class - The verification loop checking for unexpected bold dates then failed when it encountered the start date, which was bold but not expected - Add clearZoneStart to expectedBoldDates to match actual behavior To test: - yarn cypress run --spec t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts - Verify that the "should handle circulation rules date calculations and visual feedback" test now passes Signed-off-by: Paul Derscheid Signed-off-by: Nick Clemens --- .../integration/Circulation/bookingsModalDatePicker_spec.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts b/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts index 384387dab54..fc7a0d1a938 100644 --- a/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts +++ b/t/cypress/integration/Circulation/bookingsModalDatePicker_spec.ts @@ -452,6 +452,7 @@ describe("Booking Modal Date Picker Tests", () => { * └─ Renewal 1 Period (Days 60-64) * * Expected Visual Styling: + * - Day 50: Bold (start date) * - Day 59: Bold (issue period) * - Day 64: Bold (renewal 1 period) * - Day 69: Bold (renewal 2 period) @@ -561,9 +562,12 @@ describe("Booking Modal Date Picker Tests", () => { */ // Calculate expected bold dates based on circulation rules (like original test) - // Bold dates occur at period endpoints: start + issuelength, start + issuelength + renewalperiod, etc. + // Bold dates occur at: the start date itself, plus period endpoints const expectedBoldDates = []; + // Start date is always bold (see place_booking.js boldDates = [new Date(startDate)]) + expectedBoldDates.push(clearZoneStart); + // Issue period end (after issuelength days) expectedBoldDates.push( clearZoneStart.add(dateTestCirculationRules.issuelength, "day") -- 2.39.5