From 441bc303ec73bd216b6067ac8ebec61c35bc5c4e Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 3 Oct 2024 13:24:13 +0100 Subject: [PATCH] Bug 33260: (follow-up) Limit printing to non-pending on members page This patch prevent printing of notices in the 'pending' state. This ensures that email notices will not be skipped by process message queue at it's next run as we set the 'sent' status on print with this patchset. It still allows for printing of sent and failed messages which I believe is the purpose of the original patchset. --- .../prog/en/modules/members/notices.tt | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt index ca11ee6a53e..0c0f35e6493 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt @@ -40,7 +40,9 @@ [% WRAPPER 'main-container.inc' aside='circ-menu' %] [% INCLUDE 'members-toolbar.inc' %] -

Sent notices for [% INCLUDE 'patron-title.inc' %]

+

Notices for [% INCLUDE 'patron-title.inc' %]

+ +
Printing a notice will mark it as sent.
[% IF ( QUEUED_MESSAGES ) %]
@@ -66,7 +68,7 @@ [% FOREACH QUEUED_MESSAGE IN QUEUED_MESSAGES %] - + [% QUEUED_MESSAGE.time_queued | $KohaDates with_hours => 1 %] Print[% IF QUEUED_MESSAGE.status != 'pending' %] + Print + [% END %] [% END %] @@ -158,7 +162,7 @@
[% ELSE %] -
There is no record of any messages that have been sent to this patron.
+
There is no record of any messages that have been queued for this patron.
[% END %] [% END %] @@ -233,7 +237,7 @@ $(".select_all").click(function (e) { e.preventDefault(); - $("input[name='message_ids']").each(function () { + $("input[name='message_ids']:not(:disabled)").each(function () { $(this).prop("checked", true); }); }); -- 2.53.0