From 75b54eca726a69cfa649c7c25e929fc97e67255d Mon Sep 17 00:00:00 2001 From: Jacob O'Mara Date: Fri, 20 Feb 2026 13:36:38 +0000 Subject: [PATCH] Bug 38924: (follow-up) Exclude QUOTA_SELECT from session remember Prevents quota selection from being stored in or skipped by the session confirmation cookie. Hides the remember checkbox when quota is the only confirmation shown. --- circ/circulation.pl | 4 +++- .../prog/en/modules/circ/circulation.tt | 20 +++++++++++-------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index ed4831fc1c8..f017af8d6d7 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -523,6 +523,7 @@ if ( @$barcodes && $op eq 'cud-checkout' ) { next if $patron_match && scalar(@conf_keys) > 0 + && $needsconfirmation_key ne 'QUOTA_SELECT' && grep( { $needsconfirmation_key eq $_ } @conf_keys ); $template_params->{$needsconfirmation_key} = $needsconfirmation->{$needsconfirmation_key}; @@ -530,7 +531,8 @@ if ( @$barcodes && $op eq 'cud-checkout' ) { $template_params->{getBarcodeMessageIteminfo} = $item->barcode; $template_params->{NEEDSCONFIRMATION} = 1; $confirm_required = 1; - push( @{ $template_params->{sessionConfirmationKeys} }, $needsconfirmation_key ); + push( @{ $template_params->{sessionConfirmationKeys} }, $needsconfirmation_key ) + unless $needsconfirmation_key eq 'QUOTA_SELECT'; } } unless ($confirm_required) { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index 764a5634b23..ed75514c75e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -468,10 +468,12 @@ [% IF ( RENEW_ISSUE ) %] [% ELSE %] -

- - -

+ [% IF sessionConfirmationKeys.size %] +

+ + +

+ [% END %] [% END %] @@ -502,10 +504,12 @@ [% IF ( RENEW_ISSUE ) %] [% ELSE %] -

- - -

+ [% IF sessionConfirmationKeys.size %] +

+ + +

+ [% END %] [% END %] -- 2.39.5