From fc3de48bc0a5f5a7da08cd542a2d59ab417a06b6 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 3 Jul 2013 11:52:42 +0200 Subject: [PATCH] Bug 8367: Fix the maxpickupdate when we set waitingdate to NOW() ModReserveAffect get the maxpickupdate before changing the waitingdate to NOW. We should update the waitingdate and next calculate the maxpickupdate. Signed-off-by: Kyle M Hall --- C4/Reserves.pm | 15 +++++++++++---- 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 167e3b9..e56d85b 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1381,20 +1381,27 @@ sub ModReserveAffect { } else { # affect the reserve to Waiting as well. - my $item = C4::Items::GetItem( $itemnumber ); - my $maxpickupdate = GetMaxPickupDate( undef, $item ); $query = " UPDATE reserves SET priority = 0, found = 'W', waitingdate = NOW(), - maxpickupdate = ?, itemnumber = ? WHERE borrowernumber = ? AND biblionumber = ? "; $sth = $dbh->prepare($query); - $sth->execute( $maxpickupdate, $itemnumber, $borrowernumber,$biblionumber); + $sth->execute( $itemnumber, $borrowernumber,$biblionumber); + my $item = C4::Items::GetItem( $itemnumber ); + $query = " + UPDATE reserves + SET maxpickupdate = ? + WHERE borrowernumber = ? + AND biblionumber = ? + "; + my $maxpickupdate = GetMaxPickupDate( undef, $item ); + $sth = $dbh->prepare($query); + $sth->execute( $maxpickupdate, $borrowernumber, $biblionumber ); } _koha_notify_reserve( $itemnumber, $borrowernumber, $biblionumber ) if ( !$transferToDo && !$already_on_shelf ); -- 1.7.2.5