Bugzilla – Attachment 19368 Details for
Bug 7688
Change subscriptions numbering pattern and frequencies
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7688: Add unit tests for C4::Serials::Frequency
Bug-7688-Add-unit-tests-for-C4SerialsFrequency.patch (text/plain), 3.99 KB, created by
Julian Maurice
on 2013-07-03 14:01:05 UTC
(
hide
)
Description:
Bug 7688: Add unit tests for C4::Serials::Frequency
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2013-07-03 14:01:05 UTC
Size:
3.99 KB
patch
obsolete
>From aa12d8393bcffa5ca44ac4ffa38cc974885c588e Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Wed, 3 Jul 2013 11:57:32 +0000 >Subject: [PATCH] Bug 7688: Add unit tests for C4::Serials::Frequency > >--- > t/db_dependent/Serials/Frequency.t | 90 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 t/db_dependent/Serials/Frequency.t > >diff --git a/t/db_dependent/Serials/Frequency.t b/t/db_dependent/Serials/Frequency.t >new file mode 100644 >index 0000000..2b410db >--- /dev/null >+++ b/t/db_dependent/Serials/Frequency.t >@@ -0,0 +1,90 @@ >+#!/usr/bin/perl >+ >+use C4::Context; >+use Test::More tests => 27; >+use Modern::Perl; >+ >+my $dbh = C4::Context->dbh; >+$dbh->{RaiseError} = 1; >+$dbh->{AutoCommit} = 0; >+ >+use C4::Serials::Frequency; >+ >+# Start by deleting all frequencies. >+my @frequencies = GetSubscriptionFrequencies(); >+foreach my $f (@frequencies) { >+ DelSubscriptionFrequency($f->{id}); >+} >+ >+@frequencies = GetSubscriptionFrequencies(); >+is(scalar @frequencies, 0, "There is no frequencies in database"); >+ >+my $frequency = GetSubscriptionFrequency(1); >+is($frequency, undef, "GetSubscriptionFrequency(1) returns undef"); >+ >+my $rv = ModSubscriptionFrequency($frequency); >+is($rv, undef, "ModSubscriptionFrequency(undef) returns undef"); >+$frequency = {}; >+$rv = ModSubscriptionFrequency($frequency); >+is($rv, undef, "ModSubscriptionFrequency({}) returns undef"); >+# returns 0 because id doesn't exist >+$frequency = { id => 1, description => "Test frequency 1" }; >+$rv = ModSubscriptionFrequency($frequency); >+is($rv, '0E0', "ModSubscriptionFrequency({id=1,description=>'Test frequency 1'}) returns '0 but true'"); >+ >+$frequency = undef; >+my $id = AddSubscriptionFrequency($frequency); >+is($id, undef, "AddSubscriptionFrequency(undef) returns undef"); >+$frequency = {}; >+$id = AddSubscriptionFrequency($frequency); >+is($id, undef, "AddSubscriptionFrequency({}) returns undef"); >+$frequency = { description => "Test frequency 1" }; >+$id = AddSubscriptionFrequency($frequency); >+ok((defined($id) && ($id > 0)), "AddSubscriptionFrequency({description => 'Test frequency 1'}) returns frequency id"); >+ >+$frequency = GetSubscriptionFrequency($id); >+isa_ok($frequency, 'HASH', "GetSubscriptionFrequency($id)"); >+is($frequency->{description}, "Test frequency 1", "description OK"); >+is($frequency->{unit}, undef, "unit OK"); >+is($frequency->{issuesperunit}, 1, "issuesperunit OK"); >+is($frequency->{unitsperissue}, 1, "unitsperissue OK"); >+is($frequency->{expectedissuesayear}, undef, "expectedissuesayear OK"); >+is($frequency->{displayorder}, undef, "displayorder OK"); >+ >+$frequency->{description} = $frequency->{description} . " (modified)"; >+$frequency->{unit} = 'day'; >+$frequency->{unitsperissue} = 3; >+$frequency->{displayorder} = 1; >+$rv = ModSubscriptionFrequency($frequency); >+is($rv, 1, "ModSubscriptionFrequency(\$frequency) returns 1"); >+ >+$frequency = GetSubscriptionFrequency($id); >+isa_ok($frequency, 'HASH', "GetSubscriptionFrequency($id)"); >+is($frequency->{description}, "Test frequency 1 (modified)", "description OK"); >+is($frequency->{unit}, 'day', "unit OK"); >+is($frequency->{issuesperunit}, 1, "issuesperunit OK"); >+is($frequency->{unitsperissue}, 3, "unitsperissue OK"); >+is($frequency->{expectedissuesayear}, undef, "expectedissuesayear OK"); >+is($frequency->{displayorder}, 1, "displayorder OK"); >+ >+@frequencies = GetSubscriptionFrequencies(); >+is(scalar @frequencies, 1, "There is one frequency"); >+ >+diag("Add another frequency"); >+undef $frequency->{id}; >+my $id2 = AddSubscriptionFrequency($frequency); >+ >+@frequencies = GetSubscriptionFrequencies(); >+is(scalar @frequencies, 2, "There are two frequencies"); >+ >+diag("Delete one frequency"); >+DelSubscriptionFrequency($id); >+@frequencies = GetSubscriptionFrequencies(); >+is(scalar @frequencies, 1, "There is one frequency"); >+ >+diag("Delete the other frequency"); >+DelSubscriptionFrequency($id2); >+@frequencies = GetSubscriptionFrequencies(); >+is(scalar @frequencies, 0, "There is no frequency"); >+ >+$dbh->rollback; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7688
:
8110
|
8941
|
8942
|
8943
|
10145
|
10146
|
10468
|
10469
|
10470
|
10739
|
10740
|
10742
|
10743
|
10903
|
10920
|
10985
|
11299
|
11300
|
11489
|
11490
|
12268
|
12269
|
13193
|
13194
|
13195
|
13196
|
14122
|
14123
|
14124
|
14125
|
14996
|
15492
|
15493
|
15494
|
15495
|
15496
|
15534
|
15536
|
15537
|
15538
|
15539
|
15540
|
15541
|
16679
|
16680
|
16681
|
16682
|
16683
|
16684
|
16744
|
17283
|
17284
|
17285
|
17855
|
17856
|
17857
|
18298
|
18299
|
18300
|
18793
|
18794
|
18795
| 19368 |
19369
|
19370
|
19393
|
19395