From 1e4842ee5471e94e9777ee13ab841c07e993d314 Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> Date: Wed, 3 Jul 2013 15:19:00 +0200 Subject: [PATCH] [SIGNED OFF] Bug 10536 - Error when editing an order note when receiving When receiving ordrers "acqui/parcel.pl?invoiceid=1", you can add or modify an order note directly from table. After setting note "acqui/modordernotes.pl", you get an error : Can't use an undefined value as an ARRAY reference at /acqui/parcel.pl line 156. This patch corrects this, there was an error in referrer build into link to acqui/modordernotes.pl. Test plan : - Go to a vendor and click on "Receive shipments" - Click on an invoice - On an order without note, click on "Add note" - Enter a note and click "Save" => You come back to invoice and note is added - On an order with note, click on "Change note" - Enter a note and click "Save" => You come back to invoice and note is added Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, template change only. --- .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt index 415c7e8..e96033b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt @@ -200,9 +200,9 @@ [% END %] <br /> [% IF ( loop_order.notes ) %] - <p class="ordernote"><strong>Note: </strong>[% loop_order.notes|html %] [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Fbooksellerid=[% loop_order.booksellerid %]&datereceived=[% loop_order.invoicedatereceived %]&invoice=[% loop_order.invoice %]">Change note</a>]</p> + <p class="ordernote"><strong>Note: </strong>[% loop_order.notes|html %] [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Finvoiceid=[% invoiceid %]">Change note</a>]</p> [% ELSE %] - [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Fbooksellerid=[% loop_order.booksellerid %]&datereceived=[% loop_order.invoicedatereceived %]&invoice=[% loop_order.invoice %]">Add note</a>] + [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Finvoiceid=[% invoiceid %]">Add note</a>] [% END %] </td> <td><a href="/cgi-bin/koha/catalogue/showmarc.pl?id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">MARC</a> | <a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">Card</a></td> -- 1.7.9.5