Bugzilla – Attachment 19395 Details for
Bug 7688
Change subscriptions numbering pattern and frequencies
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7688: Rewrite 'for' loop in unit tests
Bug-7688-Rewrite-for-loop-in-unit-tests.patch (text/plain), 1.98 KB, created by
Julian Maurice
on 2013-07-04 10:00:45 UTC
(
hide
)
Description:
Bug 7688: Rewrite 'for' loop in unit tests
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2013-07-04 10:00:45 UTC
Size:
1.98 KB
patch
obsolete
>From 2ccb639e8d563a9989686fa01be28cd179693998 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 4 Jul 2013 12:00:10 +0200 >Subject: [PATCH] Bug 7688: Rewrite 'for' loop in unit tests > >--- > t/Serials/GetNextSeq.t | 6 +++--- > t/db_dependent/Serials/GetNextSeq.t | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/Serials/GetNextSeq.t b/t/Serials/GetNextSeq.t >index fe5a3d7..2f3a1c3 100644 >--- a/t/Serials/GetNextSeq.t >+++ b/t/Serials/GetNextSeq.t >@@ -164,7 +164,7 @@ is($seq, 'Y: 2, X: 1'); > $seq = _next_seq($subscription, $pattern); > is($seq, 'Y: 2, X: 2'); > # Back to the future >-for (my $i = 0; $i < 39; $i++) { >+for (1..39) { > $seq = _next_seq($subscription, $pattern); > } > $seq = _next_seq($subscription, $pattern); >@@ -203,7 +203,7 @@ $seq = _next_seq($subscription, $pattern); > is($seq, 'Z: 1, Y: 1, X: 4'); > $seq = _next_seq($subscription, $pattern); > is($seq, 'Z: 1, Y: 2, X: 1'); >-for (my $i = 0; $i < 24; $i++) { >+for (1..24) { > $seq = _next_seq($subscription, $pattern); > } > $seq = _next_seq($subscription, $pattern); >@@ -214,7 +214,7 @@ $seq = _next_seq($subscription, $pattern); > is($seq, 'Z: 1, Y: 8, X: 4'); > $seq = _next_seq($subscription, $pattern); > is($seq, 'Z: 2, Y: 1, X: 1'); >-for (my $i = 0; $i < 350; $i++) { >+for (1..350) { > $seq = _next_seq($subscription, $pattern); > } > $seq = _next_seq($subscription, $pattern); >diff --git a/t/db_dependent/Serials/GetNextSeq.t b/t/db_dependent/Serials/GetNextSeq.t >index a569c77..fc6e3f2 100644 >--- a/t/db_dependent/Serials/GetNextSeq.t >+++ b/t/db_dependent/Serials/GetNextSeq.t >@@ -246,7 +246,7 @@ is($seq, 'Z: 1, Y: 2, X: 3'); > $publisheddate = GetNextDate($subscription, $publisheddate); > $seq = _next_seq($subscription, $pattern, $publisheddate); > is($seq, 'Z: 1, Y: 2, X: 4'); >-for (my $i = 0; $i < 100; $i++) { >+for (1..100) { > $publisheddate = GetNextDate($subscription, $publisheddate); > $seq = _next_seq($subscription, $pattern, $publisheddate); > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7688
:
8110
|
8941
|
8942
|
8943
|
10145
|
10146
|
10468
|
10469
|
10470
|
10739
|
10740
|
10742
|
10743
|
10903
|
10920
|
10985
|
11299
|
11300
|
11489
|
11490
|
12268
|
12269
|
13193
|
13194
|
13195
|
13196
|
14122
|
14123
|
14124
|
14125
|
14996
|
15492
|
15493
|
15494
|
15495
|
15496
|
15534
|
15536
|
15537
|
15538
|
15539
|
15540
|
15541
|
16679
|
16680
|
16681
|
16682
|
16683
|
16684
|
16744
|
17283
|
17284
|
17285
|
17855
|
17856
|
17857
|
18298
|
18299
|
18300
|
18793
|
18794
|
18795
|
19368
|
19369
|
19370
|
19393
| 19395