From bab9068dac3ccc876dd2b32a5ded311c0c6047fd Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 25 Feb 2026 12:17:37 +0000 Subject: [PATCH] Bug 10190: three minor issues - overdue_notices.pl: fix verbose sprintf - remove spurious \$triggered argument (CLI 0/1 flag had replaced delay value in output) and use the \$borr string that was computed but never included in the message - overdue_notices.pl: remove %already_queued hash which was populated in _enact_trigger but never read; dead code since the refactor - C4/Overdues.pm GetBranchcodesWithOverdueRules: guard the global-rule expansion with @branchcodes check so an empty result (no rules at all) correctly returns an empty list instead of all branches --- C4/Overdues.pm | 2 +- misc/cronjobs/overdue_notices.pl | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/C4/Overdues.pm b/C4/Overdues.pm index 5d81803a1eb..65e5bfd5854 100644 --- a/C4/Overdues.pm +++ b/C4/Overdues.pm @@ -714,7 +714,7 @@ sub GetBranchcodesWithOverdueRules { distinct => 1, } )->get_column('branchcode'); - if ( !$branchcodes[0] ) { + if ( @branchcodes && !defined $branchcodes[0] ) { @branchcodes = Koha::Libraries->search( {}, { order_by => 'branchname' } )->get_column('branchcode'); } diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 3a2fa8780ef..6c6d34dad94 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -518,7 +518,6 @@ if (@myitemtypes) { @itemtypes = Koha::ItemTypes->search()->get_column('itemtype'); } -my %already_queued; my %seen = map { $_ => 1 } @branches; # Work through branches @@ -734,9 +733,9 @@ END_SQL $data->{'firstname'} || '', $data->{borrowernumber} ); - warn sprintf "Overdue matched trigger %s with delay of %s days and overdue due date of %s\n", - $i, - $triggered, $overdue_rules->{ "overdue_$i" . '_delay' }, $data->{date_due}; + warn sprintf "Overdue matched trigger %s for %s with delay of %s days and overdue due date of %s\n", + $i, $borr, + $overdue_rules->{ "overdue_$i" . '_delay' }, $data->{date_due}; warn sprintf "Using letter code '%s'\n", $overdue_rules->{ "overdue_$i" . '_notice' }; } @@ -1049,7 +1048,6 @@ sub _enact_trigger { } } - $already_queued{"$borrowernumber$trigger"} = 1; } } -- 2.53.0