From 4865deb0a6ced239e8435b8dbc833691e6e4bcc8 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 27 Feb 2026 09:32:23 +0100 Subject: [PATCH] Bug 41444: (QA follow-up) Rearrange comments Content-Type: text/plain; charset=utf-8 It would be at least helpful to add a reference to get_transfer here, since we are replacing it here. Used the opportunity to update the older comments Signed-off-by: Marcel de Rooy --- C4/Search.pm | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index e43f3497ad..cb906acd3c 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1957,6 +1957,7 @@ sub searchResults { # is item a waiting recall? my $recallstatus = ''; + # Check some statuses before checking transfer info, respect MaxSearchResultsItemsPerRecordStatusCheck unless ( $item->{withdrawn} || $item->{itemlost} @@ -1967,18 +1968,8 @@ sub searchResults { ) { - # A couple heuristics to limit how many times - # we query the database for item transfer information, sacrificing - # accuracy in some cases for speed; - # - # 1. don't query if item has one of the other statuses - # 2. don't check transit status if the bib has - # more than 20 items - # - # FIXME: to avoid having the query the database like this, and to make - # the in transit status count as unavailable for search limiting, - # should map transit status to record indexed in Zebra. - + # NOTE: We are bypassing an expected Koha::Item->get_transfer call here for speed. + # TODO: Could we index the transfer status ? my $transfer = Koha::Item::Transfers->search( { itemnumber => $item->{itemnumber}, datearrived => undef, datecancelled => undef }, { order_by => [ { '-desc' => 'datesent' }, { '-asc' => 'daterequested' } ] } -- 2.39.5