From 6edc44d4015dbb8ffd9715c81c113ed996d84fac Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 24 Feb 2026 13:22:57 +0000 Subject: [PATCH] Bug 14962: (QA follow-up) Use correct displays permission flag in API tests All 'authorized librarian' test users in displays.t and displayitems.t were created with flags => 1 (superlibrarian), which bypasses all permission checks. The comment said "displays permission" but bit 0 is the superlibrarian flag. The displays module is userflags bit 33, so use flags => 2**33 to actually test that the displays flag grants access. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize --- t/db_dependent/api/v1/displayitems.t | 10 +++++----- t/db_dependent/api/v1/displays.t | 12 ++++++------ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/t/db_dependent/api/v1/displayitems.t b/t/db_dependent/api/v1/displayitems.t index 87d9c9e9f1c..443c04a3ff5 100755 --- a/t/db_dependent/api/v1/displayitems.t +++ b/t/db_dependent/api/v1/displayitems.t @@ -47,7 +47,7 @@ subtest 'list() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -173,7 +173,7 @@ subtest 'get() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -236,7 +236,7 @@ subtest 'add() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -335,7 +335,7 @@ subtest 'update() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -441,7 +441,7 @@ subtest 'delete() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; diff --git a/t/db_dependent/api/v1/displays.t b/t/db_dependent/api/v1/displays.t index 72bb9918bb0..145f9d9a34b 100755 --- a/t/db_dependent/api/v1/displays.t +++ b/t/db_dependent/api/v1/displays.t @@ -45,7 +45,7 @@ subtest 'config() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -87,7 +87,7 @@ subtest 'list() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -162,7 +162,7 @@ subtest 'get() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -205,7 +205,7 @@ subtest 'add() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -299,7 +299,7 @@ subtest 'update() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; @@ -395,7 +395,7 @@ subtest 'delete() tests' => sub { my $librarian = $builder->build_object( { class => 'Koha::Patrons', - value => { flags => 1 } # displays permission + value => { flags => 2**33 } # displays flag = 33 } ); my $password = 'thePassword123'; -- 2.53.0