From 46089d67053fff581106be82d58774d4e5cbfab3 Mon Sep 17 00:00:00 2001 From: Jake Deery Date: Fri, 6 Mar 2026 14:40:16 +0000 Subject: [PATCH] Bug 14962: (QA follow-up) Remove unneccessary condition in moredetail This patch simplifies some of the code in moredetails.pl, as the conditions for effective_homebranch and effective_holdingbranch are no longer necessary. Sponsored-by: ByWater Solutions --- catalogue/moredetail.pl | 7 ++----- .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl index 7f6cc58c73e..2effb1e58c7 100755 --- a/catalogue/moredetail.pl +++ b/catalogue/moredetail.pl @@ -273,11 +273,8 @@ foreach my $item (@items) { $item_info->{displays} = \@displays if @displays; } - $item_info->{homebranch} = $item->effective_homebranch - if ( C4::Context->preference('UseDisplayModule') && $item->effective_homebranch ); - - $item_info->{holdingbranch} = $item->effective_holdingbranch - if ( C4::Context->preference('UseDisplayModule') && $item->effective_holdingbranch ); + $item_info->{homebranch} = $item->effective_homebranch; + $item_info->{holdingbranch} = $item->effective_holdingbranch; push @item_data, $item_info; } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt index 6b52cf975bc..1bd301d8503 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt @@ -180,7 +180,7 @@ [% IF ( item_level_itypes ) %]
  • Item type: [% ITEM_DAT.itype | html %] 
  • [% END %] - [% IF ( ITEM_DAT.ccode) %] + [% IF ( ITEM_DAT.ccode ) %]
  • Collection: [% ITEM_DAT.ccode | html %]
  • [% END %]
  • Item call number: [% ITEM_DAT.itemcallnumber | html %]
  • -- 2.50.1 (Apple Git-155)