From ac57cc05c21d488be1857de911324519c079f7d8 Mon Sep 17 00:00:00 2001 From: Paul Derscheid Date: Fri, 6 Mar 2026 17:58:06 +0100 Subject: [PATCH] Bug 41580: (QA follow-up) Fix suspend status check in batch modify holds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix typo: hold.suspened → hold.suspended, the suspension check never fired because the property name was misspelled - Restore DOM update: the tidy replaced \$("#new_suspend_status").val("1") with a local variable assignment that had no effect on the submitted form data To test: - Go to Tools → Batch modify holds - Load holds that are not suspended - Set a suspend date without changing suspend status - Submit and verify the suspend status is automatically set to 1 Signed-off-by: Paul Derscheid --- .../intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt index df2eba4502a..041ab65a594 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt @@ -616,13 +616,13 @@ var suspended = false; hold_ids.forEach(function (hold) { - if (hold.suspened) { + if (hold.suspended) { suspended = true; } }); if ((!new_suspend_status || new_suspend_status == "0" || !suspended) && new_suspend_date) { - new_suspend_status = 1; + $("#new_suspend_status").val("1"); } if (errors.length > 0) { -- 2.39.5