From c0582851b87f81b3c061d6074390f4d94e18d089 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 9 Mar 2026 09:29:08 +0000 Subject: [PATCH] Bug 41801: (QA follow-up) Remove dead ignoreSetLowestRank param and update POD The recursive self-call loop that ignoreSetLowestRank guarded against was removed by the main patch. Remove the now-unused parameter from both the function body and the POD documentation, and fix a double-word typo in the POD while here. --- C4/Reserves.pm | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index b6463705777..a65d98c4637 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1635,7 +1635,6 @@ sub SuspendAll { FixPriority({ reserve_id => $reserve_id, [rank => $rank,] - [ignoreSetLowestRank => $ignoreSetLowestRank] }); or @@ -1657,20 +1656,16 @@ then have reserves.priority set so that the first non-captured hold has its priority set to 1, the second non-captured hold has its priority set to 2, and so forth. -In both cases, holds that have the lowestPriority flag on are have their +In both cases, holds that have the lowestPriority flag on have their priority adjusted to ensure that they remain at the end of the line. -Note that the ignoreSetLowestRank parameter is meant to be used only -when FixPriority calls itself. - =cut sub FixPriority { - my ($params) = @_; - my $reserve_id = $params->{reserve_id}; - my $rank = $params->{rank} // ''; - my $ignoreSetLowestRank = $params->{ignoreSetLowestRank}; - my $biblionumber = $params->{biblionumber}; + my ($params) = @_; + my $reserve_id = $params->{reserve_id}; + my $rank = $params->{rank} // ''; + my $biblionumber = $params->{biblionumber}; my $dbh = C4::Context->dbh; -- 2.53.0