From 3bbd3149e659946140abd0a683b8b965eb7459bc Mon Sep 17 00:00:00 2001 From: Caroline Cyr La Rose Date: Mon, 1 Dec 2025 16:13:05 -0500 Subject: [PATCH] Bug 40879: (follow-up) Change OpacCiteModal to OPACCite This patch addresses QA comments on the new system preference name and description. Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose --- installer/data/mysql/atomicupdate/bug_40879.pl | 4 ++-- installer/data/mysql/mandatory/sysprefs.sql | 2 +- .../prog/en/modules/admin/preferences/opac.pref | 8 ++++---- .../bootstrap/en/includes/modals/catalog_cite.inc | 2 +- .../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug_40879.pl b/installer/data/mysql/atomicupdate/bug_40879.pl index 26649b4c18..ffb8e4c46f 100644 --- a/installer/data/mysql/atomicupdate/bug_40879.pl +++ b/installer/data/mysql/atomicupdate/bug_40879.pl @@ -10,11 +10,11 @@ return { # Do you stuffs here $dbh->do( - q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OpacCiteModal', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo')} + q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OPACCite', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo')} ); # sysprefs - say $out "Added new system preference 'OpacCiteModal'"; + say $out "Added new system preference 'OPACCite'"; }, }; diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql index ba135461d5..007fd799c6 100644 --- a/installer/data/mysql/mandatory/sysprefs.sql +++ b/installer/data/mysql/mandatory/sysprefs.sql @@ -501,7 +501,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('OpacBrowseResults','1',NULL,'Disable/enable browsing and paging search results from the OPAC detail page.','YesNo'), ('OpacBrowseSearch', '0',NULL, 'Elasticsearch only: add a page allowing users to \'browse\' all items in the collection','YesNo'), ('OpacCatalogConcerns', '0', NULL, 'Allow logged in OPAC users to report catalog concerns', 'YesNo'), -('OpacCiteModal', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo'), +('OPACCite', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo'), ('OpacCloud','0',NULL,'If ON, enables subject cloud on OPAC','YesNo'), ('OpacCoce','0', NULL, 'If on, enables cover retrieval from the configured Coce server in the OPAC', 'YesNo'), ('OPACComments','1',NULL,'If ON, enables patron reviews of bibliographic records in the OPAC','YesNo'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index d2834773e7..6abb875fd5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -427,11 +427,11 @@ OPAC: - "patrons to browse subject authorities on the OPAC." - "
NOTE: This system preference requires the misc/cronjobs/build_browser_and_cloud.pl cronjob. Ask your system administrator to schedule it." - - - pref: OpacCiteModal + - pref: OPACCite choices: - 1: Enable - 0: Disable - - the option to show the Cite modal on the bibliographic detail page. + 1: Show + 0: "Don't show" + - the cite option on OPAC bibliographic detail pages. - - pref: OpacCloud choices: diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc index 15895d18bd..b80efac826 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc @@ -1,5 +1,5 @@ [% USE raw %] -[% IF Koha.Preference('OpacCiteModal') %] +[% IF Koha.Preference('OPACCite') %]