From ed997cf5e563b3da03af75dd4e6e8ad29364d424 Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Sat, 14 Mar 2026 00:31:42 +0000 Subject: [PATCH] Bug 42101: Add timestamps to Plack logs Plack logs (e.g., plack-intranet.log) do not include timestamps in the same format as other Koha logs. Test plan 1- Disable Plack sudo koha-plack --disable kohadev sudo koha-plack --stop kohadev sudo service apache2 restart 2- Create an error mv mainpage.pl mainpage.pl.test 3- Go to: http://intranet/cgi-bin/koha/mainpage.pl 4- Check the logs: tail /var/log/koha/kohadev/intranet-error.log The date is correctly formatted: [Fri Mar 13 23:48:12.505999 2026] 5- Enable Plack sudo koha-plack --enable kohadev sudo koha-plack --start kohadev sudo service apache2 restart 6- Repeat steps 3 and 4 ==> the date format is different from step 4. 7- Modify /etc/koha/sites/kohadev/log4perl.conf and Replace [%d] with: [%d{EEE MMM dd HH:mm:ss yyyy}] (This is exactly what the patch does) 8- Restart Plack sudo koha-plack --restart kohadev 9- Repeat steps 3 and 4 The format is now consistent with step 4. [Fri Mar 13 23:52:30 2026] --- etc/log4perl.conf | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/etc/log4perl.conf b/etc/log4perl.conf index 9c16c523487..7e81b0c167e 100644 --- a/etc/log4perl.conf +++ b/etc/log4perl.conf @@ -3,7 +3,7 @@ log4perl.appender.INTRANET=Log::Log4perl::Appender::File log4perl.appender.INTRANET.filename=__LOG_DIR__/intranet-error.log log4perl.appender.INTRANET.mode=append log4perl.appender.INTRANET.layout=PatternLayout -log4perl.appender.INTRANET.layout.ConversionPattern=[%d] [%p] %m %l%n +log4perl.appender.INTRANET.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m %l%n log4perl.appender.INTRANET.utf8=1 log4perl.logger.opac = WARN, OPAC @@ -11,14 +11,14 @@ log4perl.appender.OPAC=Log::Log4perl::Appender::File log4perl.appender.OPAC.filename=__LOG_DIR__/opac-error.log log4perl.appender.OPAC.mode=append log4perl.appender.OPAC.layout=PatternLayout -log4perl.appender.OPAC.layout.ConversionPattern=[%d] [%p] %m %l%n +log4perl.appender.OPAC.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m %l%n log4perl.appender.OPAC.utf8=1 log4perl.logger.worker = WARN, WORKER log4perl.appender.WORKER=Log::Log4perl::Appender::Screen log4perl.appender.WORKER.stderr=1 log4perl.appender.WORKER.layout=PatternLayout -log4perl.appender.WORKER.layout.ConversionPattern=[%d] [%p] %m %l%n +log4perl.appender.WORKER.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m %l%n log4perl.appender.WORKER.utf8=1 log4perl.logger.z3950 = WARN, Z3950 @@ -26,7 +26,7 @@ log4perl.appender.Z3950=Log::Log4perl::Appender::File log4perl.appender.Z3950.filename=__LOG_DIR__/z3950-error.log log4perl.appender.Z3950.mode=append log4perl.appender.Z3950.layout=PatternLayout -log4perl.appender.Z3950.layout.ConversionPattern=[%d] [%p] %m %l%n +log4perl.appender.Z3950.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m %l%n log4perl.appender.Z3950.utf8=1 log4perl.logger.api = WARN, API @@ -34,7 +34,7 @@ log4perl.appender.API=Log::Log4perl::Appender::File log4perl.appender.API.filename=__LOG_DIR__/api-error.log log4perl.appender.API.mode=append log4perl.appender.API.layout=PatternLayout -log4perl.appender.API.layout.ConversionPattern=[%d] [%p] %m %l%n +log4perl.appender.API.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m %l%n log4perl.appender.API.utf8=1 log4perl.logger.sip = DEBUG, SIP @@ -42,7 +42,7 @@ log4perl.appender.SIP=Log::Log4perl::Appender::File log4perl.appender.SIP.filename=__LOG_DIR__/sip-output.log log4perl.appender.SIP.mode=append log4perl.appender.SIP.layout=PatternLayout -log4perl.appender.SIP.layout.ConversionPattern=[%d] [%P] [%p] %X{accountid}@%X{peeraddr}: %m %l%n +log4perl.appender.SIP.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%P] [%p] %X{accountid}@%X{peeraddr}: %m %l%n log4perl.appender.SIP.utf8=1 log4perl.logger.plack-opac = WARN, PLACKOPAC @@ -50,7 +50,7 @@ log4perl.appender.PLACKOPAC=Log::Log4perl::Appender::File log4perl.appender.PLACKOPAC.filename=__LOG_DIR__/plack-opac-error.log log4perl.appender.PLACKOPAC.mode=append log4perl.appender.PLACKOPAC.layout=PatternLayout -log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d] [%p] %m%n +log4perl.appender.PLACKOPAC.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m%n log4perl.appender.PLACKOPAC.utf8=1 log4perl.logger.plack-api = WARN, PLACKAPI @@ -58,7 +58,7 @@ log4perl.appender.PLACKAPI=Log::Log4perl::Appender::File log4perl.appender.PLACKAPI.filename=__LOG_DIR__/plack-api-error.log log4perl.appender.PLACKAPI.mode=append log4perl.appender.PLACKAPI.layout=PatternLayout -log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d] [%p] %m%n +log4perl.appender.PLACKAPI.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m%n log4perl.appender.PLACKAPI.utf8=1 log4perl.logger.plack-intranet = WARN, PLACKINTRANET @@ -66,7 +66,7 @@ log4perl.appender.PLACKINTRANET=Log::Log4perl::Appender::File log4perl.appender.PLACKINTRANET.filename=__LOG_DIR__/plack-intranet-error.log log4perl.appender.PLACKINTRANET.mode=append log4perl.appender.PLACKINTRANET.layout=PatternLayout -log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d] [%p] %m%n +log4perl.appender.PLACKINTRANET.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%p] %m%n log4perl.appender.PLACKINTRANET.utf8=1 log4perl.logger.edi = TRACE, EDI @@ -74,5 +74,5 @@ log4perl.appender.EDI=Log::Log4perl::Appender::File log4perl.appender.EDI.filename=__LOG_DIR__/editrace.log log4perl.appender.EDI.mode=append log4perl.appender.EDI.layout=PatternLayout -log4perl.appender.EDI.layout.ConversionPattern=[%d] [%P] [%p] %X{accountid}@%X{peeraddr}: %m %l%n +log4perl.appender.EDI.layout.ConversionPattern=[%d{EEE MMM dd HH:mm:ss yyyy}] [%P] [%p] %X{accountid}@%X{peeraddr}: %m %l%n log4perl.appender.EDI.utf8=1 -- 2.34.1