Bugzilla – Attachment 20129 Details for
Bug 10663
Holds never block renewals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
But 10663 - Revert and use CheckReserves for CanBookBeRenewed
But-10663---Revert-and-use-CheckReserves-for-CanBo.patch (text/plain), 1.05 KB, created by
Tomás Cohen Arazi
on 2013-08-06 13:52:31 UTC
(
hide
)
Description:
But 10663 - Revert and use CheckReserves for CanBookBeRenewed
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2013-08-06 13:52:31 UTC
Size:
1.05 KB
patch
obsolete
>From d7a0145f61dd675604925118eafffe35af03c5e5 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Mon, 5 Aug 2013 15:23:44 -0300 >Subject: [PATCH] But 10663 - Revert and use CheckReserves for > CanBookBeRenewed >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >It makes renewal lock by holds work again. >Unit tests as follow up > >Regards >To+ > >Sponsored-by: Universidad Nacional de Córdoba >--- > C4/Circulation.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index ca66931..aee1dbd 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2484,8 +2484,9 @@ sub CanBookBeRenewed { > $error = "too_many"; > } > >- my $resstatus = C4::Reserves::GetReserveStatus($itemnumber); >- if ( $resstatus eq "Waiting" or $resstatus eq "Reserved" ) { >+ my ( $resfound, $resrec, undef ) = C4::Reserves::CheckReserves( $itemnumber ); >+ >+ if ( defined $resfound ) { > $renewokay = 0; > $error = "on_reserve"; > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10663
:
19987
|
20129
|
20139
|
20140
|
20148
|
20149
|
20150
|
20151
|
20152
|
20153
|
20154
|
20155
|
20156
|
20362
|
20363
|
20364
|
22913