From 2bd5c73ce2e15d78b861cedfba9e30443884e8c4 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 13 Aug 2013 09:19:09 +0200 Subject: [PATCH] Bug 9811: A limit clause should be always added. By default, we want to retrieve 20 first results. --- C4/Utils/DataTables/Members.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm index e23732a..8ccb11e 100644 --- a/C4/Utils/DataTables/Members.pm +++ b/C4/Utils/DataTables/Members.pm @@ -84,12 +84,12 @@ sub search { my $orderby = dt_build_orderby($dt_params); my $limit; - if(defined $dt_params->{iDisplayStart} and defined $dt_params->{iDisplayLength}) { - # In order to avoir sql injection - $dt_params->{iDisplayStart} =~ s/\D//g; - $dt_params->{iDisplayLength} =~ s/\D//g; - $limit = "LIMIT $dt_params->{iDisplayStart},$dt_params->{iDisplayLength}"; - } + # In order to avoid sql injection + $dt_params->{iDisplayStart} =~ s/\D//g; + $dt_params->{iDisplayLength} =~ s/\D//g; + $dt_params->{iDisplayStart} //= 0; + $dt_params->{iDisplayLength} //= 20; + $limit = "LIMIT $dt_params->{iDisplayStart},$dt_params->{iDisplayLength}"; my $query = join( " ", -- 1.7.10.4