Bugzilla – Attachment 20309 Details for
Bug 10718
items with no checkouts report does not work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10718 - redefine limit input
0004-Bug-10718-redefine-limit-input.patch (text/plain), 3.18 KB, created by
Fridolin Somers
on 2013-08-13 13:53:14 UTC
(
hide
)
Description:
Bug 10718 - redefine limit input
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2013-08-13 13:53:14 UTC
Size:
3.18 KB
patch
obsolete
>From f4145fbbab515007aa4363cebe863c59f4e51fac Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Tue, 13 Aug 2013 15:33:27 +0200 >Subject: [PATCH 4/5] Bug 10718 - redefine limit input > >In reports/catalogue_out.pl form, the limit input is by defaut none. >So by default the report queries all the catalogue. >This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge. > >This patch modifies limit input to removes the "none" option. >Also reduces the number of options (same options as guided reports results per page). > >Test plan: >- Go to reports/catalogue_out.pl >=> first value "10" is selected >- Launch report >=> You see "Filtered on: limit = 10" >--- > .../prog/en/modules/reports/catalogue_out.tt | 29 ++++++++++---------- > reports/catalogue_out.pl | 2 +- > 2 files changed, 15 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >index 017c5da..47a3966 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >@@ -121,21 +121,20 @@ > <fieldset class="rows"> > <legend>Limits</legend> > <ol> >- <li><label for="numberlimit">Limit to: </label> <select name="Limit" id="numberlimit"> >- <option value ="" selected="selected">None</option> >- <option value ="5"> 5</option> >- <option value ="10">10</option> >- <option value ="15">15</option> >- <option value ="20">20</option> >- <option value ="25">25</option> >- <option value ="40">40</option> >- <option value ="50">50</option> >- <option value ="100">100</option> >- <option value ="250">250</option> >- <option value ="500">500</option> >- <option value ="700">750</option> >- <option value ="1000">1000</option> >- </select></li> >+ <li> >+ <label for="numberlimit">Limit to: </label> >+ <select name="Limit" id="numberlimit"> >+ <option value ="10">10</option> >+ <option value ="20">20</option> >+ <option value ="50">50</option> >+ <option value ="100">100</option> >+ <option value ="200">200</option> >+ <option value ="300">300</option> >+ <option value ="400">400</option> >+ <option value ="500">500</option> >+ <option value ="1000">1000</option> >+ </select> >+ </li> > <li><label for="criteria">By: </label><select name="Criteria" id="criteria"> > <option value ="" selected="selected">None</option> > <option value ="homebranch">Library</option> >diff --git a/reports/catalogue_out.pl b/reports/catalogue_out.pl >index 9e10cac..f13e96b 100755 >--- a/reports/catalogue_out.pl >+++ b/reports/catalogue_out.pl >@@ -38,7 +38,7 @@ Report that shows unborrowed items. > > my $input = new CGI; > my $do_it = $input->param('do_it'); >-my $limit = $input->param("Limit"); >+my $limit = $input->param("Limit") || 10; > my $column = $input->param("Criteria"); > my @filters = $input->param("Filter"); > >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10718
:
20306
|
20307
|
20308
|
20309
|
20310
|
20570
|
20600
|
20886
|
20887