Bugzilla – Attachment 20337 Details for
Bug 10728
subscription-renew generates unnecessary warnings in logs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10728: fix log noise generated by subscription-renew.pl
Bug-10728-fix-log-noise-generated-by-subscription-.patch (text/plain), 1.69 KB, created by
Galen Charlton
on 2013-08-14 14:55:05 UTC
(
hide
)
Description:
Bug 10728: fix log noise generated by subscription-renew.pl
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2013-08-14 14:55:05 UTC
Size:
1.69 KB
patch
obsolete
>From 9a3dac93a816bf8db4700675a0fede45721b3ee8 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 14 Aug 2013 15:26:34 +0100 >Subject: [PATCH] Bug 10728: fix log noise generated by subscription-renew.pl > >Error log is showing warnings because mode is undefined >and we are doing string comparisons on it. > >Set it to a default value (we were already assigning it a variable >which we were not using) and use the the result in the comparison > >To test, after applying the patch: > >[1] Use the renew link from the subscription detail page to renew > a subscription. >[2] Verifying that doing this did not add a warning containing > 'subscription-renew.pl: Use of uninitialized value $mode in string eq ' > to the Apache error log. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > serials/subscription-renew.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/serials/subscription-renew.pl b/serials/subscription-renew.pl >index 48861bc..47b35f0 100755 >--- a/serials/subscription-renew.pl >+++ b/serials/subscription-renew.pl >@@ -59,7 +59,7 @@ use C4::Serials; > my $query = new CGI; > my $dbh = C4::Context->dbh; > >-my $mode = $query->param('mode'); >+my $mode = $query->param('mode') || q{}; > my $op = $query->param('op') || q{}; > my $subscriptionid = $query->param('subscriptionid'); > my $done = 0; # for after form has been submitted >@@ -99,7 +99,7 @@ $template->param( > subscriptionid => $subscriptionid, > bibliotitle => $subscription->{bibliotitle}, > $op => 1, >- popup => ($query->param('mode')eq "popup"), >+ popup => ($mode eq 'popup'), > ); > > # Print the page >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10728
:
20335
|
20337
|
20338
|
20462
|
20463