From fe3526f4bc60e97269096b505ddc39e6ff805681 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Wed, 14 Aug 2013 16:37:49 +0000 Subject: [PATCH] Bug 10710: (follow-up) perltidy new code Also, I prefer the use of parentheses for function calls, even when no arguments are being passed. One missed comma turns is(GetOfflineOperation, ...) into is(GetOfflineOperation ...) Signed-off-by: Galen Charlton --- t/db_dependent/Circulation_OfflineOperation.t | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Circulation_OfflineOperation.t b/t/db_dependent/Circulation_OfflineOperation.t index a6e9a95..5d88440 100644 --- a/t/db_dependent/Circulation_OfflineOperation.t +++ b/t/db_dependent/Circulation_OfflineOperation.t @@ -71,7 +71,7 @@ is_deeply( { operationid => $offline_id, userid => 'User1', - branchcode => $samplebranch1->{branchcode}, + branchcode => $samplebranch1->{branchcode}, timestamp => "0000-00-00 00:00:00", action => 'Action1', barcode => 'CODE', @@ -80,16 +80,20 @@ is_deeply( }, "GetOffline returns offlineoperation's informations" ); -is(GetOfflineOperation,undef,'GetOfflineOperation without parameters returns undef'); -is(GetOfflineOperation(-1),undef,'GetOfflineOperation with wrong parameters returns undef'); +is( GetOfflineOperation(), undef, + 'GetOfflineOperation without parameters returns undef' ); +is( GetOfflineOperation(-1), undef, + 'GetOfflineOperation with wrong parameters returns undef' ); #Test GetOfflineOperations #TODO later: test GetOfflineOperations # Actually we cannot mock C4::Context->userenv in unit tests #Test DeleteOfflineOperation -is (DeleteOfflineOperation($offline_id),'Deleted.','Offlineoperation has been deleted'); -#is (DeleteOfflineOperation, undef, 'DeleteOfflineOperation without id returns undef'); +is( DeleteOfflineOperation($offline_id), + 'Deleted.', 'Offlineoperation has been deleted' ); + +#is (DeleteOfflineOperation(), undef, 'DeleteOfflineOperation without id returns undef'); #is (DeleteOfflineOperation(-1),undef, 'DeleteOfflineOperation with a wrong id returns undef');#FIXME #End transaction -- 1.7.10.4